From bea2d24d4dfe394f15490d80e5cdbae41e06d257 Mon Sep 17 00:00:00 2001 From: aerinon Date: Wed, 18 May 2022 14:52:47 -0600 Subject: [PATCH 1/2] Fix dungeon completion bitfield --- LTTP_RND_GeneralBugfixes.asm | 2 ++ inventory.asm | 26 +++----------------------- 2 files changed, 5 insertions(+), 23 deletions(-) diff --git a/LTTP_RND_GeneralBugfixes.asm b/LTTP_RND_GeneralBugfixes.asm index 4fb84b7..ee2bb39 100644 --- a/LTTP_RND_GeneralBugfixes.asm +++ b/LTTP_RND_GeneralBugfixes.asm @@ -433,6 +433,8 @@ org $00891D org $00893D EnableForceBlank: +DungeonMask = $0098C0 + org $00D308 DecompSwordGfx: diff --git a/inventory.asm b/inventory.asm index 0e8b298..e7ad1ba 100644 --- a/inventory.asm +++ b/inventory.asm @@ -681,31 +681,11 @@ RTL RTS .setDungeonCompletion - LDA $040C - CMP #$FF : BEQ + - LSR : AND #$0F : CMP #$08 : !BGE ++ - JSR .valueShift - ORA DungeonsCompleted : STA DungeonsCompleted - BRA + - ++ - !SUB #$08 - JSR .valueShift - BIT.b #$C0 : BEQ +++ : LDA.b #$C0 : +++ ; Make Hyrule Castle / Sewers Count for Both - ORA DungeonsCompleted+1 : STA DungeonsCompleted+1 + LDX $040C : BMI + + LDA.l DungeonMask, X + ORA DungeonsCompleted : STA DungeonsCompleted + RTS - -.valueShift - PHX - TAX : LDA.b #$01 - - - CPX #$00 : BEQ + - ASL - DEX - BRA - - + - PLX -RTS ;-------------------------------------------------------------------------------- ;-------------------------------------------------------------------------------- From 1ccc24f72f71ce3a1ab582de96f0b04eaad74717 Mon Sep 17 00:00:00 2001 From: aerinon Date: Thu, 19 May 2022 10:36:20 -0600 Subject: [PATCH 2/2] Fix dungeon completion bitfield (16-bit) --- inventory.asm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/inventory.asm b/inventory.asm index e7ad1ba..eb4ac00 100644 --- a/inventory.asm +++ b/inventory.asm @@ -682,8 +682,10 @@ RTS .setDungeonCompletion LDX $040C : BMI + + REP #$20 ; 16 bit LDA.l DungeonMask, X ORA DungeonsCompleted : STA DungeonsCompleted + SEP #$20 ; 8 bit + RTS ;--------------------------------------------------------------------------------