From ed3e2da663722562b3332fbb482c3a7cefbfe50f Mon Sep 17 00:00:00 2001
From: compiling <8335770+compiling@users.noreply.github.com>
Date: Wed, 5 Feb 2020 23:17:59 +1100
Subject: [PATCH] Log all missing chests, not just non-keys.

---
 KeyDoorShuffle.py | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/KeyDoorShuffle.py b/KeyDoorShuffle.py
index 31e538fe..4af145b1 100644
--- a/KeyDoorShuffle.py
+++ b/KeyDoorShuffle.py
@@ -1262,12 +1262,9 @@ def validate_key_placement(key_layout, world, player):
                        found_keys > counter.used_keys and any(not d.bigKey for d in counter.child_doors)
         if not can_progress:
             missing_locations = set(max_counter.free_locations.keys()).difference(found_locations)
-            missing_key_only = set(max_counter.key_only_locations.keys()).difference(counter.key_only_locations.keys())
-            if world.accessibility[player] == 'items' or True: # locations is busted - just check items are accessible for now
-                # Ok if only locking keys
-                missing_key_only = []
-                missing_locations = [l for l in missing_locations if l.item is None or (l.item.name != smallkey_name and l.item != dungeon.big_key) or "- Boss" in l.name]
-            if len(missing_locations) > 0 or len(missing_key_only) > 0:
+            missing_items = [l for l in missing_locations if l.item is None or (l.item.name != smallkey_name and l.item != dungeon.big_key) or "- Boss" in l.name]
+            #missing_key_only = set(max_counter.key_only_locations.keys()).difference(counter.key_only_locations.keys()) # do freestanding keys matter for locations?
+            if len(missing_items) > 0: #world.accessibility[player]=='locations' and (len(missing_locations)>0 or len(missing_key_only) > 0):
                 logging.getLogger('').error("Keylock - can't open locations: ")
                 for i in missing_locations:
                     logging.getLogger('').error(i)