nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

functions passed a chain explicitly NO_NONNULLS

Browse Source 
Some functions are passed an obj or monst chain,
and  the callers typically don't check them
against 0, so mark them explicitly as NO_NONNULLS

(NO_NONNULLS expands to nothing, but it flags that
some null arg analysis has been done)
This commit is contained in:
nhmall
2023-12-20 18:48:50 -05:00
parent d292ad7d17
commit 07ef4583ce
6 changed files with 23 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/end.c
View File

@@ -26,7 +26,7 @@ static void done_hangup(int);
#endif
#endif
static void disclose(int, boolean);
static void get_valuables(struct obj *);
static void get_valuables(struct obj *) NO_NONNULLS;
static void sort_valuables(struct valuable_data *, int);
static void artifact_score(struct obj *, boolean, winid);
static boolean fuzzer_savelife(int);

2
src/mon.c
View File

@@ -32,7 +32,7 @@ static boolean isspecmon(struct monst *);
static boolean validspecmon(struct monst *, int);
static int wiz_force_cham_form(struct monst *);
static struct permonst *accept_newcham_form(struct monst *, int);
static void kill_eggs(struct obj *);
static void kill_eggs(struct obj *) NO_NONNULLS;
static void pacify_guard(struct monst *);
extern const struct shclass shtypes[]; /* defined in shknam.c */

3
src/questpgr.c
View File

@@ -14,7 +14,8 @@
#endif
static const char *intermed(void);
static struct obj *find_qarti(struct obj *);
/* sometimes find_qarti(gi.invent), and gi.invent can be null */
static struct obj *find_qarti(struct obj *) NO_NONNULLS;
static const char *neminame(void);
static const char *guardname(void);
static const char *homebase(void);

6
src/save.c
View File

@@ -23,10 +23,10 @@ static void save_bubbles(NHFILE *, xint8);
static void save_stairs(NHFILE *);
static void save_bc(NHFILE *);
static void saveobj(NHFILE *, struct obj *);
static void saveobjchn(NHFILE *, struct obj **);
static void saveobjchn(NHFILE *, struct obj **) NO_NONNULLS;
static void savemon(NHFILE *, struct monst *);
static void savemonchn(NHFILE *, struct monst *);
static void savetrapchn(NHFILE *, struct trap *);
static void savemonchn(NHFILE *, struct monst *) NO_NONNULLS;
static void savetrapchn(NHFILE *, struct trap *) NO_NONNULLS;
static void save_gamelog(NHFILE *);
static void savegamestate(NHFILE *);
static void savelev_core(NHFILE *, xint8);

2
src/zap.c
View File

@@ -13,7 +13,7 @@
#define MAGIC_COOKIE 1000
static int zaptype(int);
static void probe_objchain(struct obj *);
static void probe_objchain(struct obj *) NO_NONNULLS;
static boolean zombie_can_dig(coordxy x, coordxy y);
static void polyuse(struct obj *, int, int);
static void create_polymon(struct obj *, int);