nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

github PR #694 - redundant null check

Browse Source 
Pull request from argrath:  a check for null trap in untrap_prob()
comes after an unconditional use of that trap so doesn't server any
useful purpose.

Redo a couple of comments too.  No fixes entry necessary.

Closes #694
This commit is contained in:
PatR
2022-03-11 09:58:40 -08:00
parent b82f5fa28f
commit 0fab87500e
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/trap.c
+3 -3
View File
@@ -4463,12 +4463,12 @@ dountrap(void)
/* Probability of disabling a trap. Helge Hafting */ /* Probability of disabling a trap. Helge Hafting */
static int static int
untrap_prob(struct trap *ttmp) untrap_prob(
struct trap *ttmp) /* must not be Null */
{ {
int chance = 3; int chance = 3;
/* Only spiders know how to deal with webs reliably */ /* non-spiders are less adept at dealing with webs */
/* Assume ttmp is not NULL */
if (ttmp->ttyp == WEB && !webmaker(g.youmonst.data)) if (ttmp->ttyp == WEB && !webmaker(g.youmonst.data))
chance = 7; /* 3.7: used to be 30 */ chance = 7; /* 3.7: used to be 30 */
if (Confusion || Hallucination) if (Confusion || Hallucination)