nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

fix github issue #514 - 'O' segfault

Browse Source 
The #version command retrieves the lua version number to include
in its output, but it was leaving the 'in_lua' flag set.  So if a
later 'O' command tried to complain about a bad option value, the
error reporting routine crashed.
This commit is contained in:
PatR
2021-05-21 08:40:39 -07:00
parent d6cafdc527
commit 164417f01f
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
doc/fixes37.0
+3
View File
@@ -688,6 +688,9 @@ forgetting an item's known/dknown/bknown/&c settings when picked up by unseen
avoid clearing dknown flag for globs avoid clearing dknown flag for globs
fix globby_bill_fixup to use shopkeeper instead of Null for glob pricing fix globby_bill_fixup to use shopkeeper instead of Null for glob pricing
applying a book to check readability treated novels as if they were spellbooks applying a book to check readability treated novels as if they were spellbooks
#version was leaving the 'in_lua' flag set and if subsequent 'O' issued an
error (example was an attempt to interactively set bouldersym to an
invalid value), the error routine reporting crashed via segfault
curses: 'msg_window' option wasn't functional for curses unless the binary curses: 'msg_window' option wasn't functional for curses unless the binary
also included tty support also included tty support
src/nhlua.c
+1 -1
View File
@@ -1193,7 +1193,7 @@ get_lua_version(void)
Strcpy(g.lua_ver, vs); Strcpy(g.lua_ver, vs);
} }
} }
lua_close(L); nhl_done(L);
#ifdef LUA_COPYRIGHT #ifdef LUA_COPYRIGHT
if (sizeof LUA_COPYRIGHT <= sizeof g.lua_copyright) if (sizeof LUA_COPYRIGHT <= sizeof g.lua_copyright)
Strcpy(g.lua_copyright, LUA_COPYRIGHT); Strcpy(g.lua_copyright, LUA_COPYRIGHT);