display former possessions of dead monster

Reported directly to devteam by a hardfought player and also by
entrez.  The recent mon_leaving_level() change resulted in objects
dropped by a dying monster not being displayed immediately.

It justed needed the relobj(mon, 0, FALSE) to relobj(mon, 1, FALSE)
change in m_detach() but this does some related cleanup in
mon_leaving_level()'s callers.  wormgone() takes a long worm off the
map but leaves its stale coordinates set because some code relied on
that.  This takes away the need for that but still doesn't actually
clear them.

This adds redundant 'return' statements at the end of a few void
functions that are longer than fits within a typical screen display.
They make searching for the end of the current routine in an editor
or pager easier without resorting to regular expressions and can
also be used to search for the beginning if/when preceding routine
ends in 'return' too.
This commit is contained in:
PatR
2022-05-13 14:46:02 -07:00
parent 44c225a11e
commit 1ce457f801
3 changed files with 62 additions and 26 deletions

View File

@@ -1,4 +1,4 @@
HDT-Branch: NetHack-3.7 $:$NHDT-Revision: 1.913 $ $NHDT-Date: 1652299940 2022/05/11 20:12:20 $
HDT-Branch: NetHack-3.7 $:$NHDT-Revision: 1.914 $ $NHDT-Date: 1652478351 2022/05/13 21:45:51 $
General Fixes and Modified Features
-----------------------------------
@@ -1209,6 +1209,8 @@ revised monster teleportation message handling caused magic whistle to be
changed to not operate on pets that were already adjacent; change back
revised monster teleportation message handling could produce duplicate message
when shopkeeper who left shop got returned to it
recent changes in removing a dead monster from the map didn't update screen
to show objects it dropped; they were present, just not displayed
curses: 'msg_window' option wasn't functional for curses unless the binary
also included tty support
@@ -1242,6 +1244,8 @@ tty: previous change resulted in remnants of previous level being shown on
tty: for #wizidentify, using ^I as an unseen group accelerator to pick the
'all' choice was incorrectly checking menuitem_invert_test() and
failing, so the 'all' choice wasn't being toggled on if user typed ^I
tty: changes to support utf8 resulted in lines of text windows being shown
starting at their second character
Unix: after lua changes to Makefiles, 'make spotless' for dat subdirectory
left some generated data files which should have been deleted
Windows: new tile additions in win/share did not trigger the creation of a new