nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

some parallel Make glitches noticed

Browse Source 
observed: parallel build attempts of makedefs that trampled over
one another.

attempted workaround: Add a dependency as per Pat R's suggestion.

observed: Concurrent header file movement collisions were sometimes
causing file busy errors and build failures.

workaround: Eliminate tile.h header file movement from the
Makefile build so that the collisions won't occur with that
particular file. Leave the header file tile.h in win/share as it
is in the distribution and just adjust the include path in the
rule for the specific files that use it.

observed: tiletxt.c created on-the-fly from Makefile echo statements
sometimes resulted in garbled and duplicate content in it when
parallel makes were involved, and that caused a build failure.

workaround: Instead of creating a tiletxt.c on-the-fly via echo
statements in the Makefile, simplify things and use that
same #include "tilemap.c" approach but make it an actual file
in the distribution. That makes it available for other platforms
too.
This commit is contained in:
nhmall
2022-03-13 11:06:45 -04:00
parent 2bb26da9fa
commit 2234cc256d
5 changed files with 27 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
sys/unix/Makefile.src
View File

@@ -599,7 +599,7 @@ all: $(GAME)
pregame:
$(PREGAME)
$(GAME): pregame $(SYSTEM)
$(GAME): pregame $(MAKEDEFS) $(SYSTEM)
@echo "$(GAME) is up to date."
Sysunix: $(HOSTOBJ) $(HOBJ) $(DATE_O) $(BUILDMORE) Makefile