From 2b0459e2b81fc34698635b381a31999034b97141 Mon Sep 17 00:00:00 2001 From: PatR Date: Thu, 4 Apr 2024 13:35:51 -0700 Subject: [PATCH] undo a dodgy 'O' menu optimization Normally the 'O' menu covers the status display, but not always. Toggling 'time' or 'showexp' via the "simple 'O'" menu should update the status lines. Toggling 'hitpointbar' already does so so. I didn't try to figure out why. Presumeably it triggers a different bot() call somewhere and the code here sees 'disp.bot' as reset to False. I didn't check the behavior when adding or removing a status highlight but those can change the current status display. --- src/options.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/options.c b/src/options.c index 0868f2d60..7912afafc 100644 --- a/src/options.c +++ b/src/options.c @@ -8497,14 +8497,11 @@ doset_simple(void) reset_customsymbols(); docrt_flags(opt_crt_flags); } - -/* - * I don't think the status window requires updating between - * simplemenu iterations. - if (disp.botl || disp.botlx) { + /* status may need updating if terminal is tall enough that + doset_simple menu doesn't cover up status or wide enough for + curses to honor player's choice of align_status:Right|Left */ + if (disp.botl || disp.botlx) bot(); - } - */ } while (pickedone > 0); give_opt_msg = TRUE; return ECMD_OK;