nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

Close /dev/null in child process to keep analyzer happy.

Browse Source
This commit is contained in:
nhkeni
2024-03-08 09:24:36 -05:00
parent 5e6e7c29b9
commit 2d864961bf
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/report.c
+7 -2
View File
@@ -1,4 +1,4 @@
/* NetHack 3.7 report.c $NHDT-Date: 1709571806 2024/03/04 17:03:26 $ $NHDT-Branch: keni-mdlib-followup $:$NHDT-Revision: 1.306 $ */ /* NetHack 3.7 report.c $NHDT-Date: 1709907875 2024/03/08 14:24:35 $ $NHDT-Branch: NetHack-3.7 $:$NHDT-Revision: 1.4 $ */
/* Copyright (c) Kenneth Lorber, Kensington, Maryland, 2024 */ /* Copyright (c) Kenneth Lorber, Kensington, Maryland, 2024 */
/* NetHack may be freely redistributed. See license for details. */ /* NetHack may be freely redistributed. See license for details. */
@@ -403,15 +403,20 @@ printf("ShellExecute returned: %p\n",rv); // >32 is ok
if (pid == 0) { if (pid == 0) {
char err[100]; char err[100];
# ifdef CRASHREPORT_EXEC_NOSTDERR # ifdef CRASHREPORT_EXEC_NOSTDERR
int devnull;
/* Keep the output clean - firefox spews useless errors on /* Keep the output clean - firefox spews useless errors on
* my system. */ * my system. */
(void) close(2); (void) close(2);
(void) open("/dev/null", O_WRONLY); devnull = open("/dev/null", O_WRONLY);
# endif # endif
(void) execve(CRASHREPORT, (char * const *) xargv, environ); (void) execve(CRASHREPORT, (char * const *) xargv, environ);
Sprintf(err, "Can't start " CRASHREPORT ": %s", strerror(errno)); Sprintf(err, "Can't start " CRASHREPORT ": %s", strerror(errno));
raw_print(err); raw_print(err);
# ifdef CRASHREPORT_EXEC_NOSTDERR
(void) close(devnull);
# endif
exit(1);
} else { } else {
int status; int status;
errno = 0; errno = 0;