From 2e64d35dd2aa519663c5964cc0e58fe9eed22c13 Mon Sep 17 00:00:00 2001
From: PatR <rankin@nethack.org>
Date: Fri, 16 Feb 2024 14:14:05 -0800
Subject: [PATCH] S_goodpos symbol and tile

Change the goodpos symbol, which is used to mark valid locations for
some operations when getpos() is having the player pick a spot, from
green question mark to blue dollar sign.  Dollar sign is the default
keystroke to toggle those markers off and on.
---
 include/defsym.h    |  4 +++-
 win/share/other.txt | 27 ++++++++++++++-------------
 2 files changed, 17 insertions(+), 14 deletions(-)

diff --git a/include/defsym.h b/include/defsym.h
index cda01dc0d..f51fd96ae 100644
--- a/include/defsym.h
+++ b/include/defsym.h
@@ -198,7 +198,9 @@
     PCHAR2(84, '@',  S_ss3, "shield3", "", HI_ZAP)
     PCHAR2(85, '*',  S_ss4, "shield4", "", HI_ZAP)
     PCHAR( 86, '#',  S_poisoncloud, "poison cloud", CLR_BRIGHT_GREEN)
-    PCHAR( 87, '?',  S_goodpos, "valid position", CLR_BRIGHT_GREEN)
+    /* for a time S_goodpos was a question mark, but dollar sign is the
+       default keystroke for getpos() to toggle goodpos glyphs on or off */
+    PCHAR( 87, '$',  S_goodpos, "valid position", HI_ZAP)
     /* end cmap C */
     /*                                                             */
     /* The 8 swallow symbols.  Do NOT separate.                    */
diff --git a/win/share/other.txt b/win/share/other.txt
index d716ba311..ae44ceda9 100644
--- a/win/share/other.txt
+++ b/win/share/other.txt
@@ -2291,23 +2291,24 @@ Z = (195, 195, 195)
   BBBBBBGGGGBBBBBB
   BBBBBBBBBBBBBBBB
 }
+# S_goodpos (dollar sign from generic coin tile)
 # tile 119 (valid position)
 {
   ................
   ................
-  .....GGGG.......
-  ....GGGGGG......
-  ...GGFFFFGG.....
-  ...GGF...GGF....
-  ....FF...GGF....
-  ........GGFF....
-  .......GGFF.....
-  ......GGFF......
-  ......GGF.......
-  .......FF.......
-  ......GG........
-  ......GGF.......
-  .......FF.......
+  ................
+  ........B.......
+  .......OOO......
+  ......O.BSS.....
+  ......OSB.......
+  .......OOO......
+  ........BSO.....
+  ........B.OS....
+  .......OOO.S....
+  ........BSS.....
+  ................
+  ................
+  ................
   ................
 }
 # tile 120 (swallow top left)