nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

change xchar to other typedefs

Browse Source 
One of the drivers of this change was that screen coordinates require a
type that can hold values greater than 127. Parameters to the window
port routines require a large type in order to be able to have values
a fair bit larger than COLNO and ROWNO passed to them, particularly for
their use to the right of the map window.

This splits the uses of xchar into 3 different situations, and adjusts
their type and size:

                        xchar
                          |
               -----------------------
               |          |          |
            coordxy     xint16     xint8

coordxy: Actual x or y coordinates for various things (moved to 16-bits).

xint16:  Same data size as coordxy, but for non-coordinate use (16-bits).

xint8:   There are only a few use cases initially, where it was very
         plain to see that the variable could remain as 8-bits, rather
         than be bumped to 16-bits.  There are probably more such cases
         that could be changed after additional review.

Note: This first changed all xchar variables to coordxy. Some were
reviewed and got changed to xint16 or xint8 when it became apparent that
their usage was not for coordinates.

This increments EDITLEVEL in patchlevel.h
This commit is contained in:
nhmall
2022-06-30 23:48:18 -04:00
parent 751b6e646f
commit 30b557f7d5
104 changed files with 1016 additions and 996 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
include/winprocs.h
View File

@@ -54,7 +54,7 @@ struct window_procs {
#ifdef POSITIONBAR
void (*win_update_positionbar)(char *);
#endif
void (*win_print_glyph)(winid, xchar, xchar,
void (*win_print_glyph)(winid, coordxy, coordxy,
const glyph_info *, const glyph_info *);
void (*win_raw_print)(const char *);
void (*win_raw_print_bold)(const char *);
@@ -375,7 +375,7 @@ struct chain_procs {
#ifdef POSITIONBAR
void (*win_update_positionbar)(CARGS, char *);
#endif
void (*win_print_glyph)(CARGS, winid, xchar, xchar,
void (*win_print_glyph)(CARGS, winid, coordxy, coordxy,
const glyph_info *,
const glyph_info *);
void (*win_raw_print)(CARGS, const char *);
@@ -452,7 +452,7 @@ extern void safe_cliparound(int, int);
#ifdef POSITIONBAR
extern void safe_update_positionbar(char *);
#endif
extern void safe_print_glyph(winid, xchar, xchar,
extern void safe_print_glyph(winid, coordxy, coordxy,
const glyph_info *, const glyph_info *);
extern void safe_raw_print(const char *);
extern void safe_raw_print_bold(const char *);