yet more key bindings - lack of same...
When ?i shows key bindings, at the end of each group (movement, prefixes, general, game, debug) report any commands for that group which don't have any key assigned. Movement and prefixes all have keys; they'd be pretty useless without and key bindings won't override movement commands. For general, the "keyless" are |#exploremode |#herecmdmenu |#therecmdmenu after this adds the relevant flag to their command definitions; for game, "#terrain" is the only one; the debug section has 20. There is a known problem that I've going to pretend that I didn't notice: if I use BIND=D:takeoffall then 'A' becomes unassigned, 'D' invokes #takeoffall, "#droptype" becomes keyless, and ?i reports those correctly. But if I use BIND=M:takeoffall, 'A' becomes unassigned, 'M' continues to be its usual prefix, and the "#takeoffall" command is nowhere to be seen. The code that tracks assignments is letting that case fall through the cracks. 'M' ends up assigned to both and the ?i code deliberately only shows the first.
This commit is contained in:
@@ -1,4 +1,4 @@
|
||||
/* NetHack 3.7 pager.c $NHDT-Date: 1596498194 2020/08/03 23:43:14 $ $NHDT-Branch: NetHack-3.7 $:$NHDT-Revision: 1.189 $ */
|
||||
/* NetHack 3.7 pager.c $NHDT-Date: 1607591207 2020/12/10 09:06:47 $ $NHDT-Branch: NetHack-3.7 $:$NHDT-Revision: 1.190 $ */
|
||||
/* Copyright (c) Stichting Mathematisch Centrum, Amsterdam, 1985. */
|
||||
/*-Copyright (c) Robert Patrick Rankin, 2018. */
|
||||
/* NetHack may be freely redistributed. See license for details. */
|
||||
@@ -2093,9 +2093,9 @@ static const struct {
|
||||
{ hmenu_dowhatdoes, "Info on what a given key does." },
|
||||
{ option_help, "List of game options." },
|
||||
{ dispfile_optionfile, "Longer explanation of game options." },
|
||||
{ dokeylist, "Full list of keyboard commands" },
|
||||
{ dokeylist, "Full list of keyboard commands." },
|
||||
{ hmenu_doextlist, "List of extended commands." },
|
||||
{ domenucontrols, "List menu control keys" },
|
||||
{ domenucontrols, "List menu control keys." },
|
||||
{ dispfile_license, "The NetHack license." },
|
||||
{ docontact, "Support information." },
|
||||
#ifdef PORT_HELP
|
||||
|
||||
Reference in New Issue
Block a user