nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

Fix gcc sprintf warnings

Browse Source 
Gcc 9 has become more vocal with sprintf buffer overflow
checking.  Remove these sprintf warnings by changing the
offending calls to a snprintf wrapper that will explicitly
check the result.
This commit is contained in:
Dean Luick
2021-01-08 20:33:39 -06:00
parent 8143d55d76
commit 3ef0f889e6
17 changed files with 97 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/mhitm.c
View File

@@ -576,29 +576,29 @@ int dieroll;
buf[0] = '\0';
switch (mattk->aatyp) {
case AT_BITE:
Sprintf(buf, "%s bites", magr_name);
Snprintf(buf, sizeof(buf), "%s bites", magr_name);
break;
case AT_STNG:
Sprintf(buf, "%s stings", magr_name);
Snprintf(buf, sizeof(buf), "%s stings", magr_name);
break;
case AT_BUTT:
Sprintf(buf, "%s butts", magr_name);
Snprintf(buf, sizeof(buf), "%s butts", magr_name);
break;
case AT_TUCH:
Sprintf(buf, "%s touches", magr_name);
Snprintf(buf, sizeof(buf), "%s touches", magr_name);
break;
case AT_TENT:
Sprintf(buf, "%s tentacles suck", s_suffix(magr_name));
Snprintf(buf, sizeof(buf), "%s tentacles suck", s_suffix(magr_name));
break;
case AT_HUGS:
if (magr != u.ustuck) {
Sprintf(buf, "%s squeezes", magr_name);
Snprintf(buf, sizeof(buf), "%s squeezes", magr_name);
break;
}
/*FALLTHRU*/
default:
if (!weaponhit || !mwep || !mwep->oartifact)
Sprintf(buf, "%s hits", magr_name);
Snprintf(buf, sizeof(buf), "%s hits", magr_name);
break;
}
if (*buf)