nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

fix some libnh wasm build issues

Browse Source 
emcc: error: linker setting ignored during compilation: 'ASSERTIONS' [-Wunused-command-line-argument] [-Werror]
make[1]: *** [Makefile:1306: ../targets/wasm/allmain.o] Error 1

wasm-ld: error: ../targets/wasm/version.o: undefined symbol: nomakedefs

These ones look like actual NetHack issues that this particular compile is catching due to
default -Wunused-but-set-variable.

In the interest of time today, I mostly resorted to using nhUse() on them for now, but a
follow-up by someone might be useful.

options.c:6069:13: error: variable 'ret' set but not used [-Werror,-Wunused-but-set-variable]
    boolean ret = FALSE;
            ^

restore.c:903:9: error: variable 'len' set but not used [-Werror,-Wunused-but-set-variable]
    int len = 0;
        ^

uhitm.c:4539:43: error: variable 'nsum' set but not used [-Werror,-Wunused-but-set-variable]
    int i, tmp, armorpenalty, sum[NATTK], nsum = MM_MISS,
                                          ^
This commit is contained in:
nhmall
2022-01-08 11:16:57 -05:00
parent c5901b68c4
commit 483f743304
5 changed files with 22 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/restore.c
View File

@@ -927,6 +927,7 @@ rest_stairs(NHFILE* nhfp)
if (newst)
newst->u_traversed = stway.u_traversed;
}
nhUse(len); /* unclear why this variable exists though */
}
void