nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

static analyzer bit in files.c

Browse Source 
src/files.c(4403): warning: Reading invalid data from 'buf'.
This commit is contained in:
nhmall
2023-12-22 21:47:48 -05:00
parent 7a533a911c
commit 4bc5e26082
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/files.c
View File

@@ -4396,12 +4396,14 @@ boolean
copy_bytes(int ifd, int ofd) copy_bytes(int ifd, int ofd)
{ {
char buf[BUFSIZ]; char buf[BUFSIZ];
int nfrom, nto; int nfrom, nto = 0;
do { do {
nfrom = read(ifd, buf, BUFSIZ); nfrom = read(ifd, buf, BUFSIZ);
nto = write(ofd, buf, nfrom); /* read can return -1 */
if (nto != nfrom) if (nfrom >= 0 && nfrom <= BUFSIZ)
nto = write(ofd, buf, nfrom);
if (nto != nfrom || nfrom < 0)
return FALSE; return FALSE;
} while (nfrom == BUFSIZ); } while (nfrom == BUFSIZ);
return TRUE; return TRUE;