nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

Prevent out of array access

Browse Source 
As index() can match with the string terminator, that would make
the xdir etc array references out of bounds.
This commit is contained in:
Pasi Kallinen
2015-11-01 01:32:24 +02:00
parent b0e4357c32
commit 4f616a932c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/cmd.c
+1 -1
View File
@@ -3472,7 +3472,7 @@ char sym;
register const char *dp = index(Cmd.dirchars, sym); register const char *dp = index(Cmd.dirchars, sym);
u.dz = 0; u.dz = 0;
if (!dp) if (!dp || !*dp)
return 0; return 0;
u.dx = xdir[dp - Cmd.dirchars]; u.dx = xdir[dp - Cmd.dirchars];
u.dy = ydir[dp - Cmd.dirchars]; u.dy = ydir[dp - Cmd.dirchars];