nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

'tips' fix and enhancement

Browse Source 
When 'tips' are enabled, the farlook tip displays some text at the
start of getpos().  But it clobbered the initial prompt, leaving
the screen in an ambiguous state (seemingly a normal map display,
but it is actually waiting for player to move the cursor) after
removing the tip's popup window.

Reissue the prompt.  farlook's short but misleading prompt of
"Pick an object" is changed to "Pick a monster, object or location".
I would normally include a comma before "or" but omitting it makes
the longer text seem slightly less cluttered.

The other tips are all one-line, delivered via pline().  Prefix
all of their messages with "Tip:" (which the farlook one already
uses) as a hint for using OPTIONS=!tips to shut them off.
This commit is contained in:
PatR
2024-09-14 12:53:48 -07:00
parent 60dc14952d
commit 5bb4adace0
6 changed files with 35 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/pager.c
View File

@@ -1627,7 +1627,7 @@ add_quoted_engraving(coordxy x, coordxy y, char *buf)
}
/* also used by getpos hack in getpos.c */
const char what_is_an_unknown_object[] = "an unknown object";
const char what_is_a_location[] = "a monster, object or location";
int
do_look(int mode, coord *click_cc)
@@ -1833,11 +1833,11 @@ do_look(int mode, coord *click_cc)
if (from_screen) {
if (flags.verbose)
pline("Please move the cursor to %s.",
what_is_an_unknown_object);
what_is_a_location);
else
pline("Pick an object.");
pline("Pick %s.", what_is_a_location);
ans = getpos(&cc, quick, what_is_an_unknown_object);
ans = getpos(&cc, quick, what_is_a_location);
if (ans < 0 || cc.x < 0)
break; /* done */
flags.verbose = FALSE; /* only print long question once */