nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

region save/restore

Browse Source 
When shortening/splitting wide lines I noticed that the save and
restore code for regions had a bunch of those and they could be
shortened by using an intermediate variable.  Easier to read too.

Also, change several 'unsigned int' to just 'unsigned' as is used in
most of the rest of the code.

At one point I omitted a (genericptr_t) cast (which should no longer
be necessary...) and discovered that bwrite() wasn't declaring the
input buffer it never modifies as 'const'.
This commit is contained in:
PatR
2021-12-19 19:31:19 -08:00
parent 7ccc195155
commit 63e47d8ac8
4 changed files with 153 additions and 181 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
include/extern.h
View File

@@ -2299,12 +2299,12 @@ extern void closelog(NHFILE *);
/* ### sfstruct.c ### */
#ifndef TRACEBUFFERING
extern void newread(NHFILE *, int, int, genericptr_t, unsigned int);
extern void newread(NHFILE *, int, int, genericptr_t, unsigned);
extern void bufon(int);
extern void bufoff(int);
extern void bflush(int);
extern void bwrite(int, genericptr_t, unsigned int);
extern void mread(int, genericptr_t, unsigned int);
extern void bwrite(int, const genericptr_t, unsigned);
extern void mread(int, genericptr_t, unsigned);
extern void minit(void);
extern void bclose(int);
#else
@@ -2319,11 +2319,11 @@ extern void bclose(int);
extern void Bufon(int, const char *, int);
extern void Bufoff(int, const char *, int);
extern void Bflush(int, const char *, int);
extern void Bwrite(int, genericptr_t, unsigned int, const char *, int);
extern void Bread(int, genericptr_t, unsigned int, const char *, int);
extern void Bwrite(int, const genericptr_t, unsigned, const char *, int);
extern void Bread(int, genericptr_t, unsigned, const char *, int);
extern void Binit(const char *, int);
extern void Bclose(int, const char *, int);
extern void Mread(int, genericptr_t, unsigned int, const char *, int);
extern void Mread(int, genericptr_t, unsigned, const char *, int);
extern void Minit(const char *, int);
#if defined(ZEROCOMP)
extern void zerocomp_bclose(int);