From 6d490de39cc9688fa96ddc4ea773ba83c7dc7c00 Mon Sep 17 00:00:00 2001 From: PatR Date: Wed, 6 Apr 2022 12:06:47 -0700 Subject: [PATCH] warning fix Remove redundant 'if (K)' from there_cmd_menu(). The !K case doesn't get there and that test's presence fools the compiler (oldish clang) into warning that 'npick' might be used uninitialized. --- src/cmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cmd.c b/src/cmd.c index c725502af..2c272dbea 100644 --- a/src/cmd.c +++ b/src/cmd.c @@ -1,4 +1,4 @@ -/* NetHack 3.7 cmd.c $NHDT-Date: 1647912063 2022/03/22 01:21:03 $ $NHDT-Branch: NetHack-3.7 $:$NHDT-Revision: 1.533 $ */ +/* NetHack 3.7 cmd.c $NHDT-Date: 1649272000 2022/04/06 19:06:40 $ $NHDT-Branch: NetHack-3.7 $:$NHDT-Revision: 1.539 $ */ /* Copyright (c) Stichting Mathematisch Centrum, Amsterdam, 1985. */ /*-Copyright (c) Robert Patrick Rankin, 2013. */ /* NetHack may be freely redistributed. See license for details. */ @@ -4621,7 +4621,7 @@ there_cmd_menu(int x, int y) cmdq_add_ec(move_funcs[dir][MV_WALK]); npick = 0; ch = '\0'; - } else if (K) { + } else { end_menu(win, "What do you want to do?"); npick = select_menu(win, PICK_ONE, &picks); ch = '\033';