more macOS whitelisting

X11, Qt, and util

also ensure the functional warnings.h macro definitions are used
with c++ clang compiler

include/warnings.h

@@ -31,6 +31,11 @@
 #define ACTIVATE_WARNING_PRAGMAS
 #endif
 #endif
+#if defined(__clang__) && defined(__cplusplus)
+#ifndef ACTIVATE_WARNING_PRAGMAS
+#define ACTIVATE_WARNING_PRAGMAS
+#endif
+#endif
 
 #ifdef ACTIVATE_WARNING_PRAGMAS
 #if defined(__clang__)

util/panic.c

@@ -22,6 +22,8 @@ extern void vms_abort(void);
 boolean panicking;
 void panic(const char *, ...);
 
+DISABLE_WARNING_FORMAT_NONLITERAL
+
 void panic
 VA_DECL(const char *, str)
 {
@@ -46,6 +48,8 @@ VA_DECL(const char *, str)
     exit(EXIT_FAILURE); /* redundant */
 }
 
+RESTORE_WARNING_FORMAT_NONLITERAL
+
 #ifdef ALLOCA_HACK
 /*
  * In case bison-generated foo_yacc.c tries to use alloca(); if we don't

win/Qt/qt_stat.cpp

@@ -565,6 +565,8 @@ QHBoxLayout *NetHackQtStatusWindow::InitHitpointBar()
     return hpbar; // caller will add our result to vbox layout
 }
 
+DISABLE_WARNING_FORMAT_NONLITERAL
+
 // when hitpoint bar is enabled, calculate and draw it, otherwise remove it
 void NetHackQtStatusWindow::HitpointBar()
 {
@@ -665,6 +667,8 @@ void NetHackQtStatusWindow::HitpointBar()
     }
 }
 
+RESTORE_WARNING_FORMAT_NONLITERAL
+
 /*
  * Update the displayed status.  The current code in botl.c updates
  * two lines of information.  Both lines are always updated one after

win/X11/winstat.c

@@ -642,6 +642,8 @@ tt_status_fixup(void)
     XtGetValues(X11_status_labels[0], args, num_args);
 }
 
+DISABLE_WARNING_FORMAT_NONLITERAL
+
 /* core requests updating one status field (or is indicating that it's time
    to flush all updated fields); tty-style handling */
 static void
@@ -810,6 +812,8 @@ X11_status_update_tty(int fld, genericptr_t ptr, int chg UNUSED, int percent,
     (void) XFlush(XtDisplay(X11_status_labels[0]));
 }
 
+RESTORE_WARNING_FORMAT_NONLITERAL
+
 /*ARGSUSED*/
 static void
 X11_status_update_fancy(int fld, genericptr_t ptr, int chg UNUSED,
@@ -1444,6 +1448,8 @@ hilight_label(Widget w) /* label widget */
     swap_fg_bg(w);
 }
 
+DISABLE_WARNING_FORMAT_NONLITERAL
+
 static void
 update_val(struct X_status_value *attr_rec, long new_value)
 {
@@ -1652,6 +1658,8 @@ update_val(struct X_status_value *attr_rec, long new_value)
     }
 }
 
+RESTORE_WARNING_FORMAT_NONLITERAL
+
 /* overloaded condition is being cleared without going through update_val()
    so that an alternate can be shown; put this one back to default settings */
 static void