nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

nethack -s buffer overflow fix

Browse Source 
When printing invalid player names in -s mode, it was possible to overflow
the output buffer due to a missing buffer size check.  On shared Unix-like
systems with executable stacks, this could be used as a security exploit,
eg to obtain a shell running as user or group games.
While I was at it, removed a dead block of "#if 0" code
This commit is contained in:
cohrs
2003-02-10 19:01:58 +00:00
parent 6c1d28753c
commit 8930e5b442
2 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
doc/fixes34.1
View File

@@ -379,6 +379,7 @@ see_monsters() wasn't called when you lost the innate warning intrinsic due
xorns sink if the drawbridge they're standing on is raised
applying figurines to an adjacent spot over water does drowning checks
fix sequencing of Magicbane's hit messages
avoid buffer overflow from long or too many -s params
Platform- and/or Interface-Specific Fixes