nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

remove GCC_WARN

Browse Source 
Now, the only usage of GCC_WARN is for the guard of PRINTF_F in wincurs.h.
This guard can be removed safely, as PRINTF_F is already used unconditionally in extern.h.
This commit is contained in:
SHIRAKATA Kentaro
2022-11-08 12:09:26 -08:00
committed by PatR
parent 53c4d96c59
commit 99d974333c
4 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/wincurs.h
-2
View File
@@ -58,10 +58,8 @@ typedef enum orient_type
UNDEFINED UNDEFINED
} orient; } orient;
#ifdef GCC_WARN
int wprintw(WINDOW *, const char *, ...) PRINTF_F(2, 3); int wprintw(WINDOW *, const char *, ...) PRINTF_F(2, 3);
int mvwprintw(WINDOW *, int, int, const char *, ...) PRINTF_F(4, 5); int mvwprintw(WINDOW *, int, int, const char *, ...) PRINTF_F(4, 5);
#endif
/* cursmain.c */ /* cursmain.c */
sys/unix/Makefile.src
+1 -1
View File
@@ -91,7 +91,7 @@ SYSOBJ = $(TARGETPFX)ioctl.o $(TARGETPFX)unixmain.o $(TARGETPFX)unixtty.o \
# #
# #
# if you're debugging and want gcc to check as much as possible, use: # if you're debugging and want gcc to check as much as possible, use:
# CC = gcc -W -Wimplicit -Wreturn-type -Wunused -Wformat -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -DGCC_WARN # CC = gcc -W -Wimplicit -Wreturn-type -Wunused -Wformat -Wswitch -Wshadow -Wcast-qual -Wwrite-strings
# flags may have to be changed as required # flags may have to be changed as required
# flags for 286 Xenix: # flags for 286 Xenix:
sys/unix/hints/include/compiler.370
-4
View File
@@ -133,10 +133,6 @@ CCXXFLAGS+=-Wno-deprecated-declarations
endif # WANT_WIN_QT endif # WANT_WIN_QT
endif # clang-specific ends here endif # clang-specific ends here
# enable some optional code in various NetHack source files
CFLAGS+=-DGCC_WARN
CCXXFLAGS+=-DGCC_WARN
ifdef MAKEFILE_SRC ifdef MAKEFILE_SRC
ifdef WANT_WIN_QT ifdef WANT_WIN_QT
# when switching from Qt5 to Qt6 or vice versa, any old .moc files will be # when switching from Qt5 to Qt6 or vice versa, any old .moc files will be
sys/unix/hints/include/cross-pre.370
+1 -3
View File
@@ -159,8 +159,7 @@ MSDOS_TARGET_CFLAGS = -c -O -I../include -I../sys/msdos -I../win/share \
-Wall -Wextra -Wno-missing-field-initializers -Wreturn-type -Wunused \ -Wall -Wextra -Wno-missing-field-initializers -Wreturn-type -Wunused \
-Wformat -Wswitch -Wshadow -Wwrite-strings \ -Wformat -Wswitch -Wshadow -Wwrite-strings \
-Wimplicit -Wimplicit-function-declaration -Wimplicit-int \ -Wimplicit -Wimplicit-function-declaration -Wimplicit-int \
-Wmissing-parameter-type -Wold-style-definition -Wstrict-prototypes \ -Wmissing-parameter-type -Wold-style-definition -Wstrict-prototypes
-DGCC_WARN
PDCINCL += -I$(PDCPORT) PDCINCL += -I$(PDCPORT)
PDC_TARGET_CFLAGS = $(MSDOS_TARGET_CFLAGS) -Wno-unused-parameter \ PDC_TARGET_CFLAGS = $(MSDOS_TARGET_CFLAGS) -Wno-unused-parameter \
-Wno-missing-prototypes -Wno-missing-prototypes
@@ -285,7 +284,6 @@ WASM_CFLAGS += -Wshadow
WASM_CFLAGS += $(WINCFLAGS) #WINCFLAGS set from multiw-2.370 WASM_CFLAGS += $(WINCFLAGS) #WINCFLAGS set from multiw-2.370
WASM_CFLAGS += -DSYSCF -DSYSCF_FILE=\"/sysconf\" -DSECURE WASM_CFLAGS += -DSYSCF -DSYSCF_FILE=\"/sysconf\" -DSECURE
WASM_CFLAGS += -g -I../include -DNOTPARMDECL WASM_CFLAGS += -g -I../include -DNOTPARMDECL
WASM_CFLAGS += -DGCC_WARN
# NetHack sources control # NetHack sources control
WASM_CFLAGS += -DDLB WASM_CFLAGS += -DDLB
WASM_CFLAGS += -DHACKDIR=\"$(HACKDIR)\" WASM_CFLAGS += -DHACKDIR=\"$(HACKDIR)\"