nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

curses static analyzer bits

Browse Source 
This is mostly just adding some Null guards ahead of
code that was already dereferencing pointers, so there
should be no change in behavior.

Also adds one validation of an array index that was
drawing a complaint.
This commit is contained in:
nhmall
2023-12-29 10:38:37 -05:00
parent bed3b1d667
commit 9d32956616
3 changed files with 25 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
win/curses/cursdial.c
+8 -8
View File
@@ -1078,16 +1078,16 @@ menu_win_size(nhmenu *menu)
/* Possibly reduce height if only 1 page */
if (!menu_is_multipage(menu, maxwidth, maxheight)) {
menu_item_ptr = menu->entries;
if ((menu_item_ptr = menu->entries) != 0) {
while (menu_item_ptr->next_item != NULL) {
menu_item_ptr = menu_item_ptr->next_item;
}
while (menu_item_ptr->next_item != NULL) {
menu_item_ptr = menu_item_ptr->next_item;
}
lastline = (menu_item_ptr->line_num) + menu_item_ptr->num_lines;
lastline = (menu_item_ptr->line_num) + menu_item_ptr->num_lines;
if (lastline < maxheight) {
maxheight = lastline;
if (lastline < maxheight) {
maxheight = lastline;
}
}
}