nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

remove a static analyzer warning from botl.c

Browse Source 
One static analyzer warned that there was a lower bound range check
ahead of the array index, but no upper bound check.
This commit is contained in:
nhmall
2023-01-12 16:28:39 -05:00
parent eacb68666e
commit ac87656855
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/botl.c
+3 -2
View File
@@ -1217,8 +1217,9 @@ eval_notify_windowport_field(int fld, boolean *valsetlist, int idx)
|| (fld == BL_HP && iflags.wc2_hitpointbar)) { || (fld == BL_HP && iflags.wc2_hitpointbar)) {
fldmax = curr->idxmax; fldmax = curr->idxmax;
pc = (fldmax == BL_EXP) ? exp_percentage() pc = (fldmax == BL_EXP) ? exp_percentage()
: (fldmax >= 0) ? percentage(curr, &gb.blstats[idx][fldmax]) : (fldmax >= 0 && fldmax < MAXBLSTATS)
: 0; /* bullet proofing; can't get here */ ? percentage(curr, &gb.blstats[idx][fldmax])
: 0; /* bullet proofing; can't get here */
if (pc != prev->percent_value) if (pc != prev->percent_value)
chg = 1; chg = 1;
curr->percent_value = pc; curr->percent_value = pc;