nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

fix #K3603 - multiple stacks of gold in container

Browse Source 
When taking stuff out of a container, specifying a subset count for
an item and getting the pickup_burden prompt, answering 'q' undid the
subset split but answering 'n' did not.  If the item in question was
a stack of gold, the container would end up with two stacks.  That
action could be repeated as long as any of the stacks was big enough
to trigger pickup_burden confirmation so an arbitrary number of gold
stacks could be produced.  (Eventually they would be too small for a
subset to cause an increase in encumbrance, or possibly all reduced
to just one gold piece, then no more stacks could be created.)

Situation occurred for all menustyles; traditional and via-menu needed
separate fixes.  It didn't occur for pickup off the floor.

Report was for 3.6.6 but the bug was still present in dev version.
This commit is contained in:
PatR
2022-06-02 14:44:30 -07:00
parent 57cfd7e7ed
commit afbb7e2827
3 changed files with 33 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
doc/fixes3-7-0.txt
View File

@@ -1,4 +1,4 @@
HDT-Branch: NetHack-3.7 $:$NHDT-Revision: 1.917 $ $NHDT-Date: 1652719274 2022/05/16 16:41:14 $
HDT-Branch: NetHack-3.7 $:$NHDT-Revision: 1.933 $ $NHDT-Date: 1654205933 2022/06/02 21:38:53 $
General Fixes and Modified Features
-----------------------------------
@@ -911,11 +911,10 @@ using a marker to write "novel" or "paperback book" on a known blank spellbook
was producing a randomly chosen Pratchett novel; make it fail instead
when a monster killed a pudding and it left a glob, that glob might not be
displayed on the map (wasn't an issue for killed-by-hero case)
lua's garbage collection doesn't like the way nethack is trying to use it and
issues a pair of warnings each time the relevant code gets run; they
were vanishing into a bit bucket but now they will be displayed when
running in wizard mode; we need to fix the usage rather than just
hide the feedback
if player gave a subset count when removing an item from a container, then got
the pickup_burden prompt and declined to continue, the item remained
split rather be recombined, making it possible to create multiple
stacks of gold inside a container
Fixes to 3.7.0-x Problems that Were Exposed Via git Repository
@@ -1229,6 +1228,8 @@ for menustyle:Full, fix the combination of 'A' auto-pick all plus 'P' just
for menustyle:Traditional, fix 'P' for just picked up items in inventory when
filtering what items to put into a container
restrict stunning effect to is_xport trap types
lua's garbage collection didn't like the way nethack was trying to use it and
issued a pair of warnings each time the relevant code got run
curses: 'msg_window' option wasn't functional for curses unless the binary
also included tty support