nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

Use-after-free when saving Qt message history #996

Browse Source 
Possibly resolve #996
This commit is contained in:
nhmall
2023-03-10 11:27:11 -05:00
parent 62476fe101
commit b61f55f0e4
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
win/Qt/qt_msg.cpp
+4 -3
View File
@@ -100,9 +100,10 @@ const char * NetHackQtMessageWindow::GetStr(bool init)
QListWidgetItem *item = list->item(currgetmsg++); QListWidgetItem *item = list->item(currgetmsg++);
if (item) { if (item) {
QString str = item->text(); QString str = item->text();
const char *result = str.toLatin1().constData(); if (str.toLatin1().length() < (int) sizeof historybuf - 1) {
//raw_printf("getstr[%d]='%s'", currgetmsg, result); return strcpy(historybuf, str.toLatin1().constData());
return result; //raw_printf("getstr[%d]='%s'", currgetmsg, result);
}
} }
return NULL; return NULL;
} }
win/Qt/qt_msg.h
+1
View File
@@ -42,6 +42,7 @@ private:
bool changed; bool changed;
int currgetmsg; int currgetmsg;
NetHackQtMapWindow2* map; NetHackQtMapWindow2* map;
char historybuf[BUFSZ];
private slots: private slots:
void updateFont(); void updateFont();