nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

micro fopenp() fix

Browse Source 
From a bug report.  I can't test this fix, but
inspection of the code shows that his suggested fix is clearly
necessary.  Once `bp' gets incremented, storing via `bp[BUFSZ-1]'
writes beyond the bounds of `buf' and clobbers something.
This commit is contained in:
nethack.rankin
2002-01-23 07:12:58 +00:00
parent 994dbd7694
commit bbf7ada0dd
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
doc/fixes33.2
View File

@@ -428,6 +428,7 @@ win32/tty: menus can take advantage of consoles larger than 80x25
win32/tty: add support for inverse attribute win32/tty: add support for inverse attribute
micro: prevent a guaranteed impossible() if we ever have more than (COLNO - 1) micro: prevent a guaranteed impossible() if we ever have more than (COLNO - 1)
levels in the game levels in the game
micro: fix out of bounds memory modification for file opens via PATH
msdos: placeholder tiles accepted by the thin tile builder msdos: placeholder tiles accepted by the thin tile builder
X11: viewport scrolling could scroll the the wrong place with resized window X11: viewport scrolling could scroll the the wrong place with resized window
X11: allow extra space added to map widget to be removed if widget shrinks X11: allow extra space added to map widget to be removed if widget shrinks

4
sys/share/pcsys.c
View File

@@ -1,4 +1,4 @@
/* SCCS Id: @(#)pcsys.c 3.3 1999/12/10 */ /* SCCS Id: @(#)pcsys.c 3.3 2002/01/22 */
/* NetHack may be freely redistributed. See license for details. */ /* NetHack may be freely redistributed. See license for details. */
/* /*
@@ -451,7 +451,7 @@ const char *name, *mode;
ccnt++; ccnt++;
} }
(void) strncpy(bp, name, (BUFSIZ - ccnt) - 2); (void) strncpy(bp, name, (BUFSIZ - ccnt) - 2);
bp[BUFSIZ-1] = '\0'; bp[BUFSIZ - ccnt - 1] = '\0';
if ((fp = fopen(buf, mode))) if ((fp = fopen(buf, mode)))
return fp; return fp;
if (*pp) if (*pp)