weapon skill usage

A recent newsgroup or reddit complaint stated that only 75% of a
monks attacks used martial arts.  It turned out to be true; the
'valid_weapon_attack' intended to control whether skill gets
exercised was being overloaded for skill use.  So the monk's 1..4
base damage used skill for 2..4 but not for 1.  That was never
intended (nor for other roles and other skills; a damage value of
1 is meant to miss out on a chance to train the skill for future
enhancement but should still get a skill bonus or penalty for the
current attack).
This commit is contained in:
PatR
2020-07-24 13:12:13 -07:00
parent 97cbbaa0ac
commit c1c515af9f
2 changed files with 107 additions and 46 deletions

View File

@@ -1,4 +1,4 @@
$NHDT-Branch: NetHack-3.7 $:$NHDT-Revision: 1.251 $ $NHDT-Date: 1595102359 2020/07/18 19:59:19 $
$NHDT-Branch: NetHack-3.7 $:$NHDT-Revision: 1.253 $ $NHDT-Date: 1595621524 2020/07/24 20:12:04 $
General Fixes and Modified Features
-----------------------------------
@@ -225,6 +225,7 @@ if a mind flayer's psychic blast targetted a hidden monster, feedback named
the monster but it wasn't brought out of hiding
hero poly'd into a mind flayer who used #monster to emit a psychic blast was
able to harm mindless monsters with it
some hero attacks that should have gotten a skill bonus or penalty weren't
Fixes to 3.7.0-x Problems that Were Exposed Via git Repository