nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

unixtty lint (trunk only)

Browse Source 
gcc reports "comparison between signed and unsigned".  One header file
uses unsigned long for tty flags, another uses [signed] short.  'unsigned'
seems like the best compromise, but this might accidentally introduce lint
for some other configuration.
This commit is contained in:
nethack.rankin
2012-01-23 07:11:09 +00:00
parent fa80181ed0
commit d1ffc0eaa3
1 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
sys/share/unixtty.c
View File

@@ -1,5 +1,4 @@
/* NetHack 3.5 unixtty.c $Date$ $Revision$ */ /* NetHack 3.5 unixtty.c $Date$ $Revision$ */
/* SCCS Id: @(#)unixtty.c 3.5 1990/22/02 */
/* Copyright (c) Stichting Mathematisch Centrum, Amsterdam, 1985. */ /* Copyright (c) Stichting Mathematisch Centrum, Amsterdam, 1985. */
/* NetHack may be freely redistributed. See license for details. */ /* NetHack may be freely redistributed. See license for details. */
@@ -217,22 +216,20 @@ const char *s;
void void
setftty() setftty()
{ {
register int ef = 0; /* desired value of flags & ECHO */ unsigned ef, cf;
#ifdef LINT /* cf = CBRKON(CBRKMASK); const expr to initialize is ok */ int change = 0;
register int cf = 0;
#else ef = 0; /* desired value of flags & ECHO */
register int cf = CBRKON(CBRKMASK); /* desired value of flags & CBREAK */ cf = CBRKON(CBRKMASK); /* desired value of flags & CBREAK */
#endif
register int change = 0;
iflags.cbreak = ON; iflags.cbreak = ON;
iflags.echo = OFF; iflags.echo = OFF;
/* Should use (ECHO|CRMOD) here instead of ECHO */ /* Should use (ECHO|CRMOD) here instead of ECHO */
if((curttyb.echoflgs & ECHO) != ef){ if ((unsigned)(curttyb.echoflgs & ECHO) != ef) {
curttyb.echoflgs &= ~ECHO; curttyb.echoflgs &= ~ECHO;
/* curttyb.echoflgs |= ef; */ /* curttyb.echoflgs |= ef; */
change++; change++;
} }
if((curttyb.cbrkflgs & CBRKMASK) != cf){ if ((unsigned)(curttyb.cbrkflgs & CBRKMASK) != cf) {
curttyb.cbrkflgs &= ~CBRKMASK; curttyb.cbrkflgs &= ~CBRKMASK;
curttyb.cbrkflgs |= cf; curttyb.cbrkflgs |= cf;
#ifdef USG #ifdef USG