From d51e92d4bd9f642a50a2395efa9daafbdb5de5b4 Mon Sep 17 00:00:00 2001 From: nhmall Date: Wed, 27 Dec 2023 11:10:35 -0500 Subject: [PATCH] static analyzer bit for symbols.c src/symbols.c(532): warning: Dereferencing NULL pointer. 'tmpsp' contains the same NULL value as 'lastsp' did. --- src/symbols.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/symbols.c b/src/symbols.c index 9690c4004..a7c93c341 100644 --- a/src/symbols.c +++ b/src/symbols.c @@ -529,7 +529,8 @@ parse_sym_line(char *buf, int which_set) tmpsp = lastsp; /* most recent symset */ for (i = 0; known_handling[i]; ++i) if (!strcmpi(known_handling[i], bufp)) { - tmpsp->handling = i; + if (tmpsp) + tmpsp->handling = i; break; /* for loop */ } break; @@ -544,13 +545,15 @@ parse_sym_line(char *buf, int which_set) tmpsp = lastsp; /* most recent symset */ for (i = 0; known_restrictions[i]; ++i) { if (!strcmpi(known_restrictions[i], bufp)) { - switch (i) { - case 0: - tmpsp->primary = 1; - break; - case 1: - tmpsp->rogue = 1; - break; + if (tmpsp) { + switch (i) { + case 0: + tmpsp->primary = 1; + break; + case 1: + tmpsp->rogue = 1; + break; + } } break; /* while loop */ }