remove redundant mktrap() tests
The 'tm' and 'croom' ?: tests introduced to this sprintf() a couple
of days ago will both always yield their else clause because execution
will only get into the block when they're Null (due to
if (!tm && !croom && ...) {}
that isn't visible in the diff's context).
This commit is contained in:
@@ -1741,8 +1741,7 @@ mktrap(
|
|||||||
|
|
||||||
Snprintf(errbuf, sizeof errbuf,
|
Snprintf(errbuf, sizeof errbuf,
|
||||||
"args (%d,%d,%s,%s) are invalid",
|
"args (%d,%d,%s,%s) are invalid",
|
||||||
num, mktrapflags, croom ? "[room]" : "null room",
|
num, mktrapflags, "null room", "null location");
|
||||||
tm ? "<x,y>" : "null location");
|
|
||||||
paniclog("mktrap", errbuf);
|
paniclog("mktrap", errbuf);
|
||||||
}
|
}
|
||||||
return;
|
return;
|
||||||
|
|||||||
Reference in New Issue
Block a user