nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

pointer formatting (trunk only)

Browse Source 
Hide pointer formatting in alloc.c by eliminating the need for callers
to know how big a buffer is required.  I generally prefer the caller to
pass in its own buffer for this sort of thing, but in this case the usage
is almost entirely for debugging so using static buffers results in less
clutter in the rest of the code.
This commit is contained in:
nethack.rankin
2006-07-08 03:22:40 +00:00
parent 2b530870a3
commit dbc3abb226
8 changed files with 86 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/botl.c
View File

@@ -479,13 +479,11 @@ compare_blstats(bl1, bl2)
struct istat_s *bl1, *bl2;
{
int anytype, result = 0;
char bl1_address[FMT_PTR_BUFSIZ], bl2_address[FMT_PTR_BUFSIZ];
if (!bl1 || !bl2) {
char bl1_address[FMT_PTR_BUFSIZ], bl2_address[FMT_PTR_BUFSIZ];
panic("compare_blstat: bad istat pointer %s, %s",
fmt_ptr((genericptr_t)bl1, bl1_address),
fmt_ptr((genericptr_t)bl2, bl2_address));
fmt_ptr((genericptr_t)bl1),
fmt_ptr((genericptr_t)bl2));
}
anytype = bl1->anytype;
@@ -493,8 +491,8 @@ struct istat_s *bl1, *bl2;
(anytype == ANY_IPTR || anytype == ANY_UPTR ||
anytype == ANY_LPTR || anytype == ANY_ULPTR)) {
panic("compare_blstat: invalid pointer %s, %s",
fmt_ptr((genericptr_t)bl1->a.a_void, bl1_address),
fmt_ptr((genericptr_t)bl2->a.a_void, bl2_address));
fmt_ptr((genericptr_t)bl1->a.a_void),
fmt_ptr((genericptr_t)bl2->a.a_void));
}
switch(anytype) {
@@ -558,11 +556,11 @@ struct istat_s *bl, *maxbl;
{
int result = 0;
int anytype;
if (!bl || !maxbl) {
char bl_address[FMT_PTR_BUFSIZ], maxbl_address[FMT_PTR_BUFSIZ];
impossible("percentage: bad istat pointer %s, %s",
fmt_ptr((genericptr_t)bl, bl_address),
fmt_ptr((genericptr_t)maxbl, maxbl_address));
fmt_ptr((genericptr_t)bl),
fmt_ptr((genericptr_t)maxbl));
return 0;
}