nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

strdup vs dupstr

Browse Source 
mdlib.c was avoiding alloc() and dupstr() because mdlib.o gets linked
with makedefs and makedefs used to need to avoid those.  But makedefs
doesn't avoid those anymore, so mdlib.c doesn't need to either.

Replace a couple of other strdup() calls in other files too.
This commit is contained in:
PatR
2022-02-10 10:25:25 -08:00
parent a9ba536e38
commit e02834ff87
3 changed files with 22 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/pline.c
View File

@@ -406,10 +406,10 @@ gamelog_add(unsigned int glflags, long gltime, const char *str)
struct gamelog_line *tmp;
struct gamelog_line *lst = g.gamelog;
tmp = (struct gamelog_line *)alloc(sizeof(struct gamelog_line));
tmp = (struct gamelog_line *) alloc(sizeof (struct gamelog_line));
tmp->turn = gltime;
tmp->flags = glflags;
tmp->text = strdup(str);
tmp->text = dupstr(str);
tmp->next = NULL;
while (lst && lst->next)
lst = lst->next;
@@ -420,7 +420,7 @@ gamelog_add(unsigned int glflags, long gltime, const char *str)
}
void
livelog_printf(unsigned int ll_type, const char *line, ...)
livelog_printf(unsigned ll_type, const char *line, ...)
{
char gamelogbuf[BUFSZ * 2];
va_list the_args;
@@ -435,16 +435,20 @@ livelog_printf(unsigned int ll_type, const char *line, ...)
}
#else
void
gamelog_add(unsigned int glflags UNUSED, long gltime UNUSED, const char *msg UNUSED)
gamelog_add(
unsigned glflags UNUSED, long gltime UNUSED, const char *msg UNUSED)
{
/* nothing here */
; /* nothing here */
}
void
livelog_printf(unsigned int ll_type UNUSED, const char *line UNUSED, ...)
livelog_printf(unsigned ll_type UNUSED, const char *line UNUSED, ...)
{
/* nothing here */
; /* nothing here */
}
#endif /* !CHRONICLE */
static void vraw_printf(const char *, va_list);