nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

change 'm #tip' behavior

Browse Source 
Using the 'm' prefix with #tip was putting up a menu to pick between
one or more floor containers and 'choose from invent', but that
interfered with choosing Tip as a context-sensitive item-action for
carried container.  Change 'm' to behave like it does with #eat and
\#quaff and several other commands:  skip possible candidates on the
floor and go directly to picking something from inventory.

That prevents using 'm' to force a menu of
|a - <floor container>
|i - pick a container being carried
for any menustyle when there is one floor container.  For menustyles
other than traditional, I think that's inconsequential; player needs
to answer 'n' for floor container and then get the choose-from-invent
prompt instead of 'i' and then choose.  When there are two or more
containers on hero's spot, 'm' prefix isn't needed to get that menu.

Unfortuately using 'm' to override menustyle:Traditional is still a
thing players might want to do.  Keep the prior behavior for that
style when multiple containers are present (dotip() already skipped
that menu despite 'm' when there was just one container).  Use the
new behavior (skip floor containers) when one (or none) is present.
That's inconsistent but seems more useful than alternatives.  It is
relatively unlikely that anyone who uses traditional non-menu item
selection will also use newfangled inventory item-actions so the menu
isn't likely to interfere with the latter.  Update the Guidebook to
describe how Traditional differs just in case.
This commit is contained in:
PatR
2023-03-02 05:33:16 -08:00
parent 6836eb07d8
commit f35abea80b
5 changed files with 60 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
doc/fixes3-7-0.txt
+3
View File
@@ -1494,6 +1494,9 @@ hallucination of objects incorrectly included generic objects as candidates
some actions that ask the user to pick a location allow typing '$' to show
valid spots, accept typing a second '$' prior to moving the cursor to
toggle the highlights off; ^R already did that; moving the cursor too
change 'm' prefix for #tip from 'use menu to pick among floor containers'
(since that's already the default) to 'skip floor containers' so that
context-sensitive item-action Tip directly operates on the item
curses: 'msg_window' option wasn't functional for curses unless the binary
also included tty support