From f5a9901db1d9e7ebc97f4ad1fdffebb695ca2b79 Mon Sep 17 00:00:00 2001
From: Pasi Kallinen <paxed@alt.org>
Date: Sat, 3 Sep 2022 19:10:41 +0300
Subject: [PATCH] Special levels: mkmap roomno cleanup and room removal after
 map

mkmap creates mines-style full-level maps, so it should wipe
out all the room numbers in the level away. Also, it uses
temporary rooms for making sure the map is fully joined together;
those temporary rooms were left on the map, but should've
been cleared away.

When putting down map-parts on the level, don't remove the room
data which would be under that map; the map may have holes in them
(using the "x" map char), so a room may still exist there.
I don't think it matters if there is any room data which doesn't
have any room numbers referring to it in the level.
(Usually the special levels use map right after level_init anyway,
so there wouldn't be any rooms in the level)
---
 src/mkmap.c  | 20 ++++++++++++++++++++
 src/sp_lev.c |  3 ---
 2 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/src/mkmap.c b/src/mkmap.c
index 4fca1c126..2ff4657e5 100644
--- a/src/mkmap.c
+++ b/src/mkmap.c
@@ -14,6 +14,7 @@ static schar get_map(int, int, schar);
 static void pass_one(schar, schar);
 static void pass_two(schar, schar);
 static void pass_three(schar, schar);
+static void join_map_cleanup(void);
 static void join_map(schar, schar);
 static void finish_map(schar, schar, boolean, boolean, boolean);
 static void remove_room(unsigned);
@@ -26,6 +27,7 @@ init_map(schar bg_typ)
 
     for (i = 1; i < COLNO; i++)
         for (j = 0; j < ROWNO; j++) {
+            levl[i][j].roomno = NO_ROOM;
             levl[i][j].typ = bg_typ;
             levl[i][j].lit = FALSE;
         }
@@ -240,6 +242,19 @@ flood_fill_rm(
         g.max_ry = sy;
 }
 
+/* join_map uses temporary rooms; clean up after it */
+static void
+join_map_cleanup(void)
+{
+    coordxy x, y;
+
+    for (x = 1; x < COLNO; x++)
+        for (y = 0; y < ROWNO; y++)
+            levl[x][y].roomno = NO_ROOM;
+    g.nroom = g.nsubroom = 0;
+    g.rooms[g.nroom].hx = g.subrooms[g.nsubroom].hx = -1;
+}
+
 static void
 join_map(schar bg_typ, schar fg_typ)
 {
@@ -311,6 +326,7 @@ join_map(schar bg_typ, schar fg_typ)
         }
         croom2++; /* always increment the next room */
     }
+    join_map_cleanup();
 }
 
 static void
@@ -349,6 +365,10 @@ finish_map(
 }
 
 /*
+ * TODO: If we really want to remove rooms after a map is plopped down
+ * in a special level, this needs to be rewritten - the maps may have
+ * holes in them ("x" mapchar), leaving parts of rooms still on the map.
+ *
  * When level processed by join_map is overlaid by a MAP, some rooms may no
  * longer be valid.  All rooms in the region lx <= x < hx, ly <= y < hy are
  * removed.  Rooms partially in the region are truncated.  This function
diff --git a/src/sp_lev.c b/src/sp_lev.c
index 53f3460c1..2e079b746 100644
--- a/src/sp_lev.c
+++ b/src/sp_lev.c
@@ -6649,9 +6649,6 @@ TODO: g.coder->croom needs to be updated
                 else if (splev_init_present && levl[x][y].typ == ICE)
                     levl[x][y].icedpool = icedpools ? ICED_POOL : ICED_MOAT;
             }
-        if (g.coder->lvl_is_joined && !g.in_mk_themerooms)
-            remove_rooms(g.xstart, g.ystart,
-                         g.xstart + g.xsize, g.ystart + g.ysize);
     }
 
  skipmap: