From 1702f55c183e49b37507a1017eb3af2283696075 Mon Sep 17 00:00:00 2001
From: PatR <rankin@nethack.org>
Date: Sun, 26 May 2019 07:24:52 -0700
Subject: [PATCH] savelev() pasta

Avoid some of the spaghetti [mostly the alternate call to
savecemetery()] in savelev().  There should be no change in behavior.
---
 src/save.c | 94 ++++++++++++++++++++++++++++++++----------------------
 1 file changed, 56 insertions(+), 38 deletions(-)

diff --git a/src/save.c b/src/save.c
index d9d3662fd..b1e31bc49 100644
--- a/src/save.c
+++ b/src/save.c
@@ -1,4 +1,4 @@
-/* NetHack 3.6	save.c	$NHDT-Date: 1558856435 2019/05/26 07:40:35 $  $NHDT-Branch: NetHack-3.6 $:$NHDT-Revision: 1.119 $ */
+/* NetHack 3.6	save.c	$NHDT-Date: 1558880688 2019/05/26 14:24:48 $  $NHDT-Branch: NetHack-3.6 $:$NHDT-Revision: 1.120 $ */
 /* Copyright (c) Stichting Mathematisch Centrum, Amsterdam, 1985. */
 /*-Copyright (c) Michael Allison, 2009. */
 /* NetHack may be freely redistributed.  See license for details. */
@@ -139,8 +139,7 @@ dosave0()
         return 0;
 #endif
 
-    HUP if (iflags.window_inited)
-    {
+    HUP if (iflags.window_inited) {
         nh_uncompress(fq_save);
         fd = open_savefile();
         if (fd > 0) {
@@ -476,35 +475,59 @@ int mode;
     short tlev;
 #endif
 
-    /* if we're tearing down the current level without saving anything
-       (which happens upon entrance to the endgame or after an aborted
-       restore attempt) then we don't want to do any actual I/O */
-    if (mode == FREE_SAVE)
+    /*
+     *  Level file contents:
+     *    version info (handled by caller);
+     *    save file info (compression type; also by caller);
+     *    process ID;
+     *    internal level number (ledger number);
+     *    bones info;
+     *    actual level data.
+     *
+     *  If we're tearing down the current level without saving anything
+     *  (which happens at end of game or upon entrance to endgame or
+     *  after an aborted restore attempt) then we don't want to do any
+     *  actual I/O.  So when only freeing, we skip to the bones info
+     *  portion (which has some freeing to do), then jump quite a bit
+     *  further ahead to the middle of the 'actual level data' portion.
+     */
+    if (mode != FREE_SAVE) {
+        /* WRITE_SAVE (probably ORed with FREE_SAVE), or COUNT_SAVE */
+
+        /* purge any dead monsters (necessary if we're starting
+           a panic save rather than a normal one, or sometimes
+           when changing levels without taking time -- e.g.
+           create statue trap then immediately level teleport) */
+        if (iflags.purge_monsters)
+            dmonsfree();
+
+        if (fd < 0)
+            panic("Save on bad file!"); /* impossible */
+#ifdef MFLOPPY
+        count_only = (mode & COUNT_SAVE);
+#endif
+        if (lev >= 0 && lev <= maxledgerno())
+            level_info[lev].flags |= VISITED;
+        bwrite(fd, (genericptr_t) &hackpid, sizeof hackpid);
+#ifdef TOS
+        tlev = lev;
+        tlev &= 0x00ff;
+        bwrite(fd, (genericptr_t) &tlev, sizeof tlev);
+#else
+        bwrite(fd, (genericptr_t) &lev, sizeof lev);
+#endif
+    }
+
+    /* bones info comes before level data; the intent is for an external
+       program ('hearse') to be able to match a bones file with the
+       corresponding log file entry--or perhaps just skip that?--without
+       the guessing that was needed in 3.4.3 and without having to
+       interpret level data to find where to start; unfortunately it
+       still needs to handle all the data compression schemes */
+    savecemetery(fd, mode, &level.bonesinfo);
+    if (mode == FREE_SAVE) /* see above */
         goto skip_lots;
 
-    /* purge any dead monsters (necessary if we're starting
-       a panic save rather than a normal one, or sometimes
-       when changing levels without taking time -- e.g.
-       create statue trap then immediately level teleport) */
-    if (iflags.purge_monsters)
-        dmonsfree();
-
-    if (fd < 0)
-        panic("Save on bad file!"); /* impossible */
-#ifdef MFLOPPY
-    count_only = (mode & COUNT_SAVE);
-#endif
-    if (lev >= 0 && lev <= maxledgerno())
-        level_info[lev].flags |= VISITED;
-    bwrite(fd, (genericptr_t) &hackpid, sizeof hackpid);
-#ifdef TOS
-    tlev = lev;
-    tlev &= 0x00ff;
-    bwrite(fd, (genericptr_t) &tlev, sizeof tlev);
-#else
-    bwrite(fd, (genericptr_t) &lev, sizeof lev);
-#endif
-    savecemetery(fd, mode, &level.bonesinfo);
     savelevl(fd, (boolean) ((sfsaveinfo.sfi1 & SFI1_RLECOMP) == SFI1_RLECOMP));
     bwrite(fd, (genericptr_t) lastseentyp, sizeof lastseentyp);
     bwrite(fd, (genericptr_t) &monstermoves, sizeof monstermoves);
@@ -521,10 +544,7 @@ int mode;
 
     /* from here on out, saving also involves allocated memory cleanup */
  skip_lots:
-    /* this comes before the map, so need cleanup here if we skipped */
-    if (mode == FREE_SAVE)
-        savecemetery(fd, mode, &level.bonesinfo);
-    /* must be saved before mons, objs, and buried objs */
+    /* timers and lights must be saved before monsters and objects */
     save_timers(fd, mode, RANGE_LEVEL);
     save_light_sources(fd, mode, RANGE_LEVEL);
 
@@ -542,13 +562,11 @@ int mode;
                 level.monsters[x][y] = 0;
         fmon = 0;
         ftrap = 0;
-        fobj = 0;
-        level.buriedobjlist = 0;
-        billobjs = 0;
+        fobj = level.buriedobjlist = billobjs = 0;
         /* level.bonesinfo = 0; -- handled by savecemetery() */
     }
     save_engravings(fd, mode);
-    savedamage(fd, mode);
+    savedamage(fd, mode); /* pending shop wall and/or floor repair */
     save_regions(fd, mode);
     if (mode != FREE_SAVE)
         bflush(fd);