container vulnerability to water damage

We used to have the contents of chests and large boxes be immune to
water damage, oilskin sacks immune unless the sack was cursed, other
containers be vulnerable.  Some reddit discussion about ice boxes in
unnethack indicates that they are treated like oilskin sacks, which
makes sense.  This adds that to nethack and also makes chests and
large boxes behave similarly.  So it's now:  nothing is immune even
when cursed (except statues); oilskin sacks, ice boxes, and other
boxes are immune to water damage unless cursed; all other containers
vulnerable even when not cursed.
|
|                  Old                  New
|immune all        statues,             statues
| the time         chests, large boxes
|
|immune when BU,   oilskin sacks        oilskin sacks,
| vulnerable if C                       ice boxes,
|                                       chests, large boxes
|
|vulnerable        ordinary sacks,      ordinary sacks,
| all the time     bags of holding,     bags of holding
|                  ice boxes
|
I suspect that the old ice box classification might have been an
accident caused by the Is_box() predicate yielding False for it.

The changes won't make much difference to actual play.  Chests and
large boxes are rarely carried and never start out cursed, ice boxes
even more so, and sacks/bags haven't been changed.  However, players
might intentionally curse a container to keep strong pets from
picking it up, or be carrying a box because they haven't found a bag
yet and then muck about with fountains or thrones and get it cursed.
This commit is contained in:
PatR
2021-04-17 12:41:30 -07:00
parent 7880be807a
commit f90bb4fb6b
3 changed files with 20 additions and 14 deletions

View File

@@ -457,9 +457,12 @@ opening/unlocking magic zapped at monster holding the hero will release hold
when riding, allow scroll of remove curse to affect to affect steed's saddle
the 'scores' option for final top ten display left default values in place if
only some of the three settings were set; 'scores:own' should have
produced '0 top/0 around/own' but ended up as '3 top/2 around/own';
also, allow 'scores:none' as shorthand for 'scores:0 t/0 a/!o' (player
will to told whether new score made the list but no scores get shown)
produced '0 top/0 around/own' but ended up as '3 top/2 around/own'
allow 'scores:none' as shorthand for 'scores:0 t/0 a/!o' (player will be told
whether new score made the list but no scores will be shown)
contents of chests, large boxes, and ice boxes are now immune to water damage
unless the container is cursed, same as for oilskin sacks (previously,
chests+large boxes were always immune and ice boxes always vulnerable)
Fixes to 3.7.0-x Problems that Were Exposed Via git Repository