nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

redundant comparison code watchman_canseeu()

Browse Source 
m_canseeu() already includes couldsee() so redundant code was flagged.

: #define m_canseeu(m) \
:     ((!Invis || perceives((m)->data))                      \
:      && !Underwater                                        \
:      && couldsee((m)->mx, (m)->my))

static boolean
watchman_canseeu(struct monst *mtmp)
{
    if (is_watch(mtmp->data) && mtmp->mcansee && m_canseeu(mtmp)
        && couldsee(mtmp->mx, mtmp->my) && mtmp->mpeaceful)
        return TRUE;
    return FALSE;
}
This commit is contained in:
nhmall
2022-09-07 07:52:33 -04:00
parent e952f67f2c
commit feebb561d6
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/dig.c
+1 -1
View File
@@ -1207,7 +1207,7 @@ static boolean
watchman_canseeu(struct monst *mtmp) watchman_canseeu(struct monst *mtmp)
{ {
if (is_watch(mtmp->data) && mtmp->mcansee && m_canseeu(mtmp) if (is_watch(mtmp->data) && mtmp->mcansee && m_canseeu(mtmp)
&& couldsee(mtmp->mx, mtmp->my) && mtmp->mpeaceful) && mtmp->mpeaceful)
return TRUE; return TRUE;
return FALSE; return FALSE;
} }