Files
nethack/win/Qt
PatR 0ec355bdb4 fix github issue #426 - binding special commands
Binding 'repeat' (DOAGAIN, or redo) to a different key than ^A
didn't work as intended because the code that used it was
checking for DOAGAIN (a key value from config.h) instead of
g.Cmd.spkeys[NHKF_DOAGAIN] (the key currently bound to repeat).

Contrary to the github issue, re-bound prefix keys worked ok for
me if followed by a direction.  However, they behaved strangely
if followed by anything else.  If the keystroke was stolen from
some other command and that command hadn't been bound to another
key, following the prefix with a non-direction could end up
executing the command that used to own the key.  For example,
 BIND=d:nopickup
to use 'd' to move without auto-pickup would work if you used
d<direction> but if you used d<something-else> if would execute
the drop command.

The NHKF_REQMENU prefix could be bound to some key other than
'm' but it only worked as intended if the new key was a movement
prefix.

This also makes DOAGAIN be unconditional.  If it is deleted or
commented out in config.h, the default binding will be '\000' so
unusable (freeing up ^A for something), but still be available
to be bound to some key (perhaps even ^A).

This also includes an unrelated change to mdlib.c.  The comments
added to config.h will force a full rebuild.  Changing mdlib.c
now rather than separately will avoid forcing that twice.

Fixes #426
2020-12-25 13:57:05 -08:00
..
2019-12-07 17:07:50 +01:00
2019-12-07 17:07:50 +01:00
2020-08-12 17:01:03 -07:00
2019-12-07 17:07:50 +01:00
2019-12-07 17:07:50 +01:00
2019-12-07 17:07:50 +01:00
2020-08-12 17:01:03 -07:00
2019-12-07 17:07:50 +01:00
2020-11-19 04:48:15 -08:00
2020-12-14 12:32:43 -08:00
2019-12-07 17:07:50 +01:00
2020-10-01 03:16:14 -07:00
2020-09-03 19:01:36 -07:00
2020-08-12 17:01:03 -07:00
2019-12-07 17:07:50 +01:00
2020-09-23 16:40:26 -07:00
2020-08-17 15:41:33 -07:00
2020-12-17 13:55:10 -08:00
2020-11-30 03:18:45 -08:00
2020-11-15 18:19:53 -08:00
2020-10-28 01:43:53 -07:00
2020-08-12 17:01:03 -07:00
2020-08-12 17:01:03 -07:00
2020-08-12 17:01:03 -07:00
2019-12-07 17:07:50 +01:00
2020-12-06 02:58:05 -08:00
2020-12-06 02:58:05 -08:00
2020-11-05 14:28:17 -08:00
2019-12-07 17:07:50 +01:00
2020-11-05 14:36:13 -08:00
2020-11-05 14:36:13 -08:00
2020-10-26 22:37:40 -07:00
2019-12-07 17:07:50 +01:00
2020-10-08 10:18:44 -07:00
2020-10-08 10:18:44 -07:00
2020-12-06 02:58:05 -08:00
2020-10-31 15:34:47 -07:00