9de8b03c03
Suppress close to 400 warnings generated by gcc on the win/X11/*.c code,
most due to -Wwrite-strings which makes string literals implicitly have
the 'const' attribute. (Since modifying a string literal results in
undefined behavior, that is an appropriate check to have enabled, but
it can be troublesome since string literals have type 'char *' and code
that uses them that way is correct provided it avoids modifying them.)
113 warning: initialization discards qualifiers from pointer target type
127 warning: assignment discards qualifiers from pointer target type
29 warning: passing argument discards qualifiers from pointer target type
109 warning: unused parameter
12 warning: comparison between signed and unsigned
The nhStr() hack casts to 'char *', explicitly removing 'const', for
situations where it isn't feasible to make code directly honor const.
The vast marjority of uses are for the second parameter to XtSetArg(),
which is a macro that actually performs an assignment with the second
argument rather than passing it in a function. It takes values like
'XtNtop', which doesn't need to be altered (although in many places I
changed that to nhStr(XtNtop) for uniformity with the surrounding code,
and 'XtNbottom', which does need to have the extra const stripping to
avoid a warning. Go figure.
The nhUse() hack actually uses its argument in a meaningless way if the
code is compiled with FORCE_ARG_USAGE defined. When GCC_WARN is defined,
FORCE_ARG_USAGE will be enabled if it hasn't been already. Example:
/*ARGUSED*/
int foo(arg)
int arg; /* not used */
{
+ nhUse(arg);
return 0;
}
The extra line will expand to ';' when FORCE_ARG_USAGE is not defined
or too
nhUse_dummy += (unsigned)arg;
when it is. I figured direct assignment might lead to a different
warning by some compilers in a situation like
nhUse(arg);
nhUse(otherarg);
where the first assignment would be clobbered by the second, and using
bitwise operations or safer '+= (arg != 0)' would most likely generate
more non-useful code. Some tweaking might turn out to be necessary.
180 lines
3.9 KiB
C
180 lines
3.9 KiB
C
/* NetHack 3.5 winval.c $NHDT-Date: 1430899139 2015/05/06 07:58:59 $ $NHDT-Branch: master $:$NHDT-Revision: 1.5 $ */
|
|
/* NetHack 3.5 winval.c $Date: 2009/05/06 10:56:06 $ $Revision: 1.4 $ */
|
|
/* SCCS Id: @(#)winval.c 3.5 1992/3/7 */
|
|
/* Copyright (c) Dean Luick, 1992 */
|
|
/* NetHack may be freely redistributed. See license for details. */
|
|
|
|
/*
|
|
* Routines that define a name-value label widget pair that fit inside a
|
|
* form widget.
|
|
*/
|
|
#include <stdio.h>
|
|
|
|
#ifndef SYSV
|
|
#define PRESERVE_NO_SYSV /* X11 include files may define SYSV */
|
|
#endif
|
|
|
|
#include <X11/Intrinsic.h>
|
|
#include <X11/StringDefs.h>
|
|
#include <X11/Xaw/Label.h>
|
|
#include <X11/Xaw/Form.h>
|
|
#include <X11/Xaw/Cardinals.h>
|
|
|
|
#ifdef PRESERVE_NO_SYSV
|
|
# ifdef SYSV
|
|
# undef SYSV
|
|
# endif
|
|
# undef PRESERVE_NO_SYSV
|
|
#endif
|
|
|
|
#include "hack.h" /* #define for const for non __STDC__ compilers */
|
|
#include "winX.h"
|
|
|
|
#define WNAME "name"
|
|
#define WVALUE "value"
|
|
|
|
|
|
Widget
|
|
create_value(parent, name_value)
|
|
Widget parent;
|
|
const char *name_value;
|
|
{
|
|
Widget form, name;
|
|
Arg args[8];
|
|
Cardinal num_args;
|
|
|
|
num_args = 0;
|
|
XtSetArg(args[num_args], XtNborderWidth, 0); num_args++;
|
|
XtSetArg(args[num_args], nhStr(XtNdefaultDistance), 0); num_args++;
|
|
form = XtCreateManagedWidget(name_value,
|
|
formWidgetClass,
|
|
parent, args, num_args);
|
|
|
|
num_args = 0;
|
|
XtSetArg(args[num_args], XtNjustify, XtJustifyRight); num_args++;
|
|
XtSetArg(args[num_args], XtNborderWidth, 0); num_args++;
|
|
XtSetArg(args[num_args], XtNlabel, name_value); num_args++;
|
|
XtSetArg(args[num_args], XtNinternalHeight, 0); num_args++;
|
|
name = XtCreateManagedWidget(WNAME,
|
|
labelWidgetClass,
|
|
form, args, num_args);
|
|
|
|
num_args = 0;
|
|
XtSetArg(args[num_args], XtNjustify, XtJustifyRight); num_args++;
|
|
XtSetArg(args[num_args], XtNborderWidth, 0); num_args++;
|
|
XtSetArg(args[num_args], nhStr(XtNfromHoriz), name); num_args++;
|
|
XtSetArg(args[num_args], XtNinternalHeight, 0); num_args++;
|
|
(void) XtCreateManagedWidget(WVALUE,
|
|
labelWidgetClass,
|
|
form, args, num_args);
|
|
return form;
|
|
}
|
|
|
|
void
|
|
set_name(w, new_label)
|
|
Widget w;
|
|
const char *new_label;
|
|
{
|
|
Arg args[1];
|
|
Widget name;
|
|
|
|
name = XtNameToWidget(w, WNAME);
|
|
XtSetArg(args[0], XtNlabel, new_label);
|
|
XtSetValues(name, args, ONE);
|
|
}
|
|
|
|
void
|
|
set_name_width(w, new_width)
|
|
Widget w;
|
|
int new_width;
|
|
{
|
|
Arg args[1];
|
|
Widget name;
|
|
|
|
name = XtNameToWidget(w, WNAME);
|
|
XtSetArg(args[0], XtNwidth, new_width);
|
|
XtSetValues(name, args, ONE);
|
|
}
|
|
|
|
int
|
|
get_name_width(w)
|
|
Widget w;
|
|
{
|
|
Arg args[1];
|
|
Dimension width;
|
|
Widget name;
|
|
|
|
name = XtNameToWidget(w, WNAME);
|
|
XtSetArg(args[0], XtNwidth, &width);
|
|
XtGetValues(name, args, ONE);
|
|
return (int) width;
|
|
}
|
|
|
|
|
|
void
|
|
set_value(w, new_value)
|
|
Widget w;
|
|
const char *new_value;
|
|
{
|
|
Arg args[1];
|
|
Widget val;
|
|
|
|
val = XtNameToWidget(w, WVALUE);
|
|
XtSetArg(args[0], XtNlabel, new_value);
|
|
XtSetValues(val, args, ONE);
|
|
}
|
|
|
|
void
|
|
set_value_width(w, new_width)
|
|
Widget w;
|
|
int new_width;
|
|
{
|
|
Arg args[1];
|
|
Widget val;
|
|
|
|
val = XtNameToWidget(w, WVALUE);
|
|
XtSetArg(args[0], XtNwidth, new_width);
|
|
XtSetValues(val, args, ONE);
|
|
}
|
|
|
|
int
|
|
get_value_width(w)
|
|
Widget w;
|
|
{
|
|
Arg args[1];
|
|
Widget val;
|
|
Dimension width;
|
|
|
|
val = XtNameToWidget(w, WVALUE);
|
|
XtSetArg(args[0], XtNwidth, &width);
|
|
XtGetValues(val, args, ONE);
|
|
return (int) width;
|
|
}
|
|
|
|
/* Swap foreground and background colors (this is the best I can do with */
|
|
/* a label widget, unless I can get some init hook in there). */
|
|
void
|
|
hilight_value(w)
|
|
Widget w;
|
|
{
|
|
swap_fg_bg(XtNameToWidget(w, WVALUE));
|
|
}
|
|
|
|
/* Swap the foreground and background colors of the given widget */
|
|
void
|
|
swap_fg_bg(w)
|
|
Widget w;
|
|
{
|
|
Arg args[2];
|
|
Pixel fg, bg;
|
|
|
|
XtSetArg(args[0], XtNforeground, &fg);
|
|
XtSetArg(args[1], XtNbackground, &bg);
|
|
XtGetValues(w, args, TWO);
|
|
|
|
XtSetArg(args[0], XtNforeground, bg);
|
|
XtSetArg(args[1], XtNbackground, fg);
|
|
XtSetValues(w, args, TWO);
|
|
}
|
|
|