Even though a goodpos failure in mnearto() would return 0 to the caller and trigger proper overcrowding handling for mtmp, the 'othermon' would be left with its mx,my set to 0,0 under that circumstance and then trigger a mon_sanity_check() failure and accompanying impossible() message a short while afterwards. This also includes the addition of some flags that proved useful for troubleshooting the mystery sanity_check failure and helping to understand some of the code paths the struct monst data had been through. They are only used for inspection when issues are reported or when debugging, they don't presently control the code flow. Their setting and use is done in an overloaded way that should not intrude on the existing use of mspare1 for MIGR_LEFTOVERS. mon->mstate is just a pseudonym for mon->mspare1 and does not alter save file content.
107 KiB
107 KiB