Fix dungeon completion bitfield

2022-05-18 14:52:47 -06:00
parent 15cc72c1e0
commit 003278f7e0
2 changed files with 5 additions and 23 deletions
--- a/LTTP_RND_GeneralBugfixes.asm
+++ b/LTTP_RND_GeneralBugfixes.asm
@@ -472,6 +472,8 @@ org $00891D
 org $00893D
 EnableForceBlank:

+DungeonMask = $0098C0
+
 org $00D308
 DecompSwordGfx:

--- a/inventory.asm
+++ b/inventory.asm
@@ -707,31 +707,11 @@ RTL
 RTS

 .setDungeonCompletion
-        LDA $040C
-	CMP #$FF : BEQ +
-		LSR : AND #$0F : CMP #$08 : !BGE ++
-			JSR .valueShift
-			ORA DungeonsCompleted : STA DungeonsCompleted
-			BRA +
-		++
-			!SUB #$08
-			JSR .valueShift
-			BIT.b #$C0 : BEQ +++ : LDA.b #$C0 : +++ ; Make Hyrule Castle / Sewers Count for Both
-			ORA DungeonsCompleted+1 : STA DungeonsCompleted+1
+	LDX $040C : BMI +
+		LDA.l DungeonMask, X
+		ORA DungeonsCompleted : STA DungeonsCompleted
 	+
 RTS
-
-.valueShift
-	PHX
-	TAX : LDA.b #$01
-	-
-		CPX #$00 : BEQ +
-		ASL
-		DEX
-	BRA -
-	+
-	PLX
-RTS
 ;--------------------------------------------------------------------------------

 ;--------------------------------------------------------------------------------