nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

fix missing prototype warning for Qt SELECTSAVED

Browse Source 
For whatever reason, Qt relies on late #define of SELECTSAVED
inside files.c.

The prototype in extern.h is therefore not picked up with
as a result of #include "hack.h"

Options were:
1. remove the conditional #if defined(SELECTSAVED) around the
   prototype in extern.h entirely
2. Move the forced #define of SELECTSAVED above the #include "hack.h"
3. Alter the conditional in extern.h to also include the condition for
   the forced #define of SELECTSAVED inside files.c

This goes with option #3.
This commit is contained in:
nhmall
2021-01-23 09:37:47 -05:00
parent 4487c1014f
commit 093c53bead
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/extern.h
View File

@@ -804,7 +804,7 @@ E int FDECL(parse_sym_line, (char *, int));
E void FDECL(paniclog, (const char *, const char *));
E void FDECL(testinglog, (const char *, const char *, const char *));
E int FDECL(validate_prefix_locations, (char *));
#ifdef SELECTSAVED
#if defined(SELECTSAVED) || (defined(UNIX) && defined(QT_GRAPHICS))
E char *FDECL(plname_from_file, (const char *));
#endif
E char **NDECL(get_saved_games);