nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

resolve a static analyzer complaint in glyphs.c

Browse Source 
src/glyphs.c(680): warning: Dereferencing NULL pointer.
                   'other' contains the same NULL value as 'obj_glyphs[idx].u' did.
This commit is contained in:
nhmall
2024-10-12 15:26:47 -04:00
parent 67cfdf6843
commit 3885949c5b
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/glyphs.c
View File

@@ -675,12 +675,14 @@ shuffle_customizations(void)
tmp_customcolor[i] = other_customcolor;
tmp_color256idx[i] = other_color256idx;
#ifdef ENHANCED_SYMBOLS
tmp_u[i] = (struct unicode_representation *)
alloc(sizeof *tmp_u[i]);
*tmp_u[i] = *other;
if (other->utf8str != NULL) {
tmp_u[i]->utf8str = (uint8 *)
dupstr((const char *) other->utf8str);
if (other) {
tmp_u[i] = (struct unicode_representation *) alloc(
sizeof *tmp_u[i]);
*tmp_u[i] = *other;
if (other->utf8str != NULL) {
tmp_u[i]->utf8str =
(uint8 *) dupstr((const char *) other->utf8str);
}
}
#endif
} else {