old pull request #609 - neutral #offer feedback

Pull request from Vivit-R was to change feedback when offering on a
neutral altar from "your sacrifice is consumed in a cloud of smoke"
to "... in a puff of smoke".  There were multiple comments, some
agreeing and some disagreeing but no better alternatives offered.

I'm ambivalent to whether any alteration was needed, but think "puff"
sounds rather passive.  I looked at a lot of synonyms and considered
"veil of smoke" and "haze of smoke" and even "puff of vapor", but
finally settled on "plume of smoke".  It isn't something that appears
and is gone in an instant like the lawful flash of light and chaotic
burst of flame, but I think it is more interesting than cloud or puff.

The PR's commit hasn't been used since 100% of its content is being
superseded.

Closes #609

src/pray.c

@@ -1417,10 +1417,10 @@ consume_offering(struct obj *otmp)
         Your("sacrifice disappears!");
     else
         Your("sacrifice is consumed in a %s!",
-             u.ualign.type == A_LAWFUL
+             (u.ualign.type == A_LAWFUL)
                 ? "flash of light"
-                : u.ualign.type == A_NEUTRAL
-                    ? "cloud of smoke"
+                : (u.ualign.type == A_NEUTRAL)
+                    ? "plume of smoke"
                     : "burst of flame");
     if (carried(otmp))
         useup(otmp);