nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

fix pull request #491 - color of converted altar

Browse Source 
A display optimization assumed that the color of a glyph wouldn't
change unless the glyph itself changed, but there is a single glyph
for all altars and unaligned is shown with a different color than
the three aligned ones.  If there was an unaligned altar outside
of Gehennom (orcish mine town, some quests) and an invisible hero
(without see invisible) converted it, it stayed the old color until
there was some other reason to update that screen location.

Fixes #491
This commit is contained in:
PatR
2021-04-17 17:16:44 -07:00
parent f90bb4fb6b
commit c79e7601a0
2 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
doc/fixes37.0
View File

@@ -605,6 +605,8 @@ wearing a ring of protection and any amulet behaved as if wearing an amulet of
messaging for genetic engineer attacks had several problems
give genetic engineers teleport capability (as they had in slash'em); 'port
away after polymorphing someone so that they don't just repeat that
if an invisible hero managed to convert an unaligned altar to an aligned one
with color enabled, altar wasn't immediately redrawn with new color
curses: 'msg_window' option wasn't functional for curses unless the binary
also included tty support

14
src/display.c
View File

@@ -1593,11 +1593,17 @@ show_glyph(int x, int y, int glyph)
if (g.gbuf[y][x].glyph != glyph
#ifndef UNBUFFERED_GLYPHINFO
/* I don't think we have to test for changes in TTYCHAR or COLOR
because they typically only change if the glyph changed */
|| g.gbuf[y][x].glyphinfo.glyphflags != glyphinfo.glyphflags
/* flags might change (single object vs pile, monster tamed or pet
gone feral), color might change (altar's alignment converted by
invisible hero), but ttychar normally won't change unless the
glyph does too (changing boulder symbol would be an exception,
but that triggers full redraw so doesn't matter here); still,
be thorough and check everything */
|| g.gbuf[y][x].glyphinfo.glyphflags != glyphinfo.glyphflags
|| g.gbuf[y][x].glyphinfo.ttychar != glyphinfo.ttychar
|| g.gbuf[y][x].glyphinfo.color != glyphinfo.color
#endif
|| iflags.use_background_glyph ) {
|| iflags.use_background_glyph) {
g.gbuf[y][x].glyph = glyph;
g.gbuf[y][x].gnew = 1;
#ifndef UNBUFFERED_GLYPHINFO