nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

sp_lvl: fix memory leak on lspo_region

Browse Source 
If tutorial is entered, we get following leak on exit:

=================================================================
==81358==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 96 byte(s) in 3 object(s) allocated from:
    #0 0x7f6996edefdf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
        #1 0x5601c255bcbb in alloc /home/miku/src/NetHack/src/alloc.c:71

Indirect leak of 5064 byte(s) in 3 object(s) allocated from:
    #0 0x7f6996edefdf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
        #1 0x5601c255be1e in alloc /home/miku/src/NetHack/src/alloc.c:71
	    #2 0x5601c255be1e in dupstr /home/miku/src/NetHack/src/alloc.c:236

SUMMARY: AddressSanitizer: 5160 byte(s) leaked in 6 allocation(s).

Fix this by freeing the cloned selection before returning.
This commit is contained in:
Mika Kuoppala
2023-12-04 23:08:12 +02:00
committed by Pasi Kallinen
parent a2aa4edd51
commit e6c4838161
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sp_lev.c
View File

@@ -6191,6 +6191,8 @@ lspo_region(lua_State *L)
selection_do_grow(sel, W_ANY);
selection_iterate(sel, sel_set_lit, (genericptr_t) &rlit);
selection_free(sel, TRUE);
/* TODO: skip the rest of this function? */
return 0;
} else {