nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity

remove unnecessary condition on parseoptions()

Browse Source 
`opts` here is always non-null, otherwise it leads segv at earlier code.
This commit is contained in:
SHIRAKATA Kentaro
2022-06-20 20:32:23 +09:00
parent e783c82b84
commit eb03b1a6db
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/options.c
View File

@@ -630,12 +630,10 @@ parseoptions(
if (pfx_match && optresult == optn_err) {
char pfxbuf[BUFSZ], *pfxp;
if (opts) {
Snprintf(pfxbuf, sizeof pfxbuf, "%s", opts);
if ((pfxp = strchr(pfxbuf, ':')) != 0)
*pfxp = '\0';
config_error_add("bad option suffix variation '%s'", pfxbuf);
}
Snprintf(pfxbuf, sizeof pfxbuf, "%s", opts);
if ((pfxp = strchr(pfxbuf, ':')) != 0)
*pfxp = '\0';
config_error_add("bad option suffix variation '%s'", pfxbuf);
return FALSE;
}
if (got_match && optresult == optn_err)