nethack-gwaa-kiwi/nethack
1
0
Fork 0
Code Pull Requests Activity
13,175 Commits 2 Branches 0 Tags
1c7faa0585a80b58b6fd1be5e2b9a6a2b9d8d00b
Commit Graph
22 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
SHIRAKATA Kentaro 1c7faa0585 Add explicit cast to void 
All other these calls not using a return value have a cast.
 2022-03-19 20:50:40 +09:00
SHIRAKATA Kentaro b82f5fa28f remove redundant null-check on untrap_prob() 
`ttmp` should not be NULL here, otherwise this function will crash at earlier code.
 2022-03-11 09:56:35 -08:00
SHIRAKATA Kentaro 467777539e add explicit cast on somexy() call 
All other somexy() calls not using a return value have a cast.
 2022-03-10 06:12:01 +09:00
SHIRAKATA Kentaro 757139476f move validations before their first use 2022-02-25 22:41:21 -08:00
SHIRAKATA Kentaro dc7d434f98 add missing initializer of jcp 2022-02-20 14:43:33 -08:00
SHIRAKATA Kentaro bb5150445a Check the return value of nhl_init() on com_pager_core() 
nhl_init() can return NULL.
 2022-02-12 07:45:46 -08:00
SHIRAKATA Kentaro 7c1dba3f0b remove redundant null-check on christen_orc() 
rndorcname() returns buf2 itself, so orcname is never NULL.
 2022-02-11 16:52:50 +09:00
SHIRAKATA Kentaro 9bd8bcdcfb move null-check on tin_details() 
Move null-check of obj and buf before their first use.
 2022-02-10 05:16:29 +09:00
SHIRAKATA Kentaro 128966bfe1 move null-check on savelev() 
Move null-check of nhfp before its first use.
 2022-02-10 01:25:13 +09:00
SHIRAKATA Kentaro b55954b2a1 Add null-check on repairable_damage() 
Add null-check of dam before its first use.
 2022-02-09 05:54:27 +09:00
SHIRAKATA Kentaro cf4cc3fa93 add null-check on fill_special_room() 
Add null-check of croom before its first use.
 2022-02-08 17:20:50 +09:00
SHIRAKATA Kentaro b87dd4423b remove redundant code 
The values of lx and ly are always assigned just before their usage.
So, assignments in advance are redundant.
 2022-02-05 20:31:17 +09:00
SHIRAKATA Kentaro cf810630de add missing const 
If you want to declare a pointer which the address pointed to is constant,
you should declare it as like `static const char *const var = "...";`.

This commit supplies missing `const` and prevents some programming
error in the future.
 2022-01-29 11:13:01 -08:00
SHIRAKATA Kentaro a2a40c6b0b fix typo in Guidebook.tex 2022-01-10 21:36:16 +09:00
SHIRAKATA Kentaro 546377581a use %d for short 
obj->otyp is short, so corresponding format string is %d.

(from Coverity Scan)
 2021-11-24 06:30:00 +09:00
SHIRAKATA Kentaro bfd79f5c9d use %lu for unsigned long 
`curr->tid` is unsigned long, so use `%lu`.
 2021-10-23 01:07:40 +09:00
SHIRAKATA Kentaro 62e6b5a336 guard lua_close() 
nhl_done() can be called with L == NULL.
So lua_close() should be guarded.
 2021-10-22 02:13:17 +09:00
SHIRAKATA Kentaro 1f651f8f00 initialize attknum 
`attknum` is declared without initialization, and is used on
find_roll_to_hit().  This leads unexpected result.
 2021-10-21 08:48:23 -04:00
SHIRAKATA Kentaro 0f36d7ac6e revert MAX_RADIUS change 
On 59818fb, MAX_RADIUS was changed from 15 to 16 to intend to support
"radius 0".  But MAX_RADIUS doesn't means the range but outer bound of
the radius table, so it should not be changed, and this change led
possible out-of-bound access on view_from() and do_clear_area() in
vision.c.

This commit reverts the change and avoids the problem.
 2021-10-21 08:48:23 -04:00
SHIRAKATA Kentaro ed543d7832 fix pointer precedence 2021-10-21 17:41:13 +09:00
SHIRAKATA Kentaro 96679152ef Supply missing changes 
Some changes applied to Guidebook.mn were not applied to Guidebook.tex.
This commit supplies them.
 2021-09-25 23:28:16 +09:00
SHIRAKATA Kentaro 83c626b707 delete extra lines 2021-09-23 03:30:57 +09:00