Commit Graph

12089 Commits

Author SHA1 Message Date
Pasi Kallinen
4050ec1670 Improve special level shop and door linking
When creating a shop via des.region, allow creating the shop door
either with a map character in a des.map, or with des.door
before or after the shop region.

Also allow a shop door to open directly into another shop.
2021-07-09 13:58:49 +03:00
PatR
c4ec1e9ada tribute update: Carpe Jugulum
Add four new passages to Carpe Jugulum, bringing total to 12.

A couple of fixes for the Fifth Elephant are mixed in:  page reference
and italics for passage #1, correct the spelling of "doublet" in #9.
2021-07-08 19:13:26 -07:00
Pasi Kallinen
491adc6a69 Mark some extended commands as no-fuzzer
... instead of checking the fuzzer being on in the commands themselves.
2021-07-08 11:35:43 +03:00
Pasi Kallinen
57cfcd9ed0 Fix error marking scroll as used up
Forgot to change this when reorganizing the scroll effects
into separate functions.
2021-07-08 10:22:13 +03:00
Pasi Kallinen
5abf948116 Fix movecmd always returning a direction
My recent commit broke the 'm' (menu request) -prefix, because
a thinko in movecmd made it always return a direction.
2021-07-08 07:52:45 +03:00
Pasi Kallinen
2f1b3a34ad Split can-engrave checks out of engraving function 2021-07-07 16:41:58 +03:00
nhmall
216c26aaef do vs2017 warnings.h a little differently than vs2019
fixes #545
2021-07-07 09:05:22 -04:00
Pasi Kallinen
caee59b131 Split potion effects into separate functions 2021-07-07 12:54:35 +03:00
Pasi Kallinen
4b54f4f18a Split scroll effects into separate functions 2021-07-07 12:02:59 +03:00
PatR
ee13fb36ac fix github issue #542 - clumsy "it" message
when encountering a hiding monster that's still unseen after being
revealed (so most likely invisible when hero lacks see invisible).
Change
|Wait!  There's an it hiding under <an object>!
to
!Wait!  There's something hiding under <an object>!
when hero tries to move onto the object.

Also, when a hidden monster reveals itself by attacking, change
|It was hidden under <an object>!
usually followed by "It hits." or "It misses."
to
|Something was hidden under <an object>!
without changing whatever follows.

Fixes #542
2021-07-04 17:47:04 -07:00
Pasi Kallinen
581f12797f Allow using rush/run prefix to fastmove in getloc 2021-07-03 18:22:24 +03:00
Pasi Kallinen
db68395d69 Movement key reworking
Put the rush and run movement keys into g.Cmd instead of bit twiddling
the normal walk keys in multiple places to get the run and rush keys.

Allow meta keys in getpos. Use the normal running keys to fast-move
in getpos, instead of explicit HJKL - I polled couple places online,
and number_pad users did not use the HJKL keys in getpos.

Make meta keys work even after a prefix key.
2021-07-03 18:20:24 +03:00
PatR
0ba7ff46b9 fix pull request #541 - itemized shop billing
when perm_invent is displayed.  The persistent inventory window
showed unpaid items with their prices, but when using itemized
billing those prices went away when an item was purchased.

The prices and item-by-item prompting continued correctly with
remaining unpaid items; only the perm_invent display was affected.

Fixes #541
2021-07-02 18:52:17 -07:00
Pasi Kallinen
552431e966 Split coord truncate-to-map into separate function 2021-07-01 14:29:04 +03:00
PatR
4c7734ebbd fix #K3378 - quaffing lit potion of oil
should cure sliming.  Implement the suggestion that quaffing a
burning potion of oil while turning into green slime will cure the
latter.

It's somewhat iffy since the slime is on the outside moving in and
the burning oil ends up on the inside, but the message sequence is
|You burn your face.
|The slime that covers you is burned away!
and it could be that igniting part of the slime quickly spreads to
the rest.

Implemented for monsters as well as for the hero.  They will light
and drink the oil in a single turn in the extremely rare situation
where they actually have a potion of oil and need to use it.
2021-06-30 17:33:18 -07:00
Pasi Kallinen
183e31ef14 Fix swapped DIR_UP and DIR_DOWN
I don't think this had any effect on gameplay, but it was still wrong.
2021-06-28 23:34:54 +03:00
Pasi Kallinen
efae7c7c47 Missed couple direction enum places 2021-06-28 17:41:04 +03:00
Pasi Kallinen
f25a6e26ee Use enums and defines for directions 2021-06-27 15:46:56 +03:00
PatR
dad804e118 web spinning tweak for Sokoban
When spiders try to spin webs, don't let them do so in Sokoban
unless the level has already been solved or the spider can see the
stairs up (which was the simplest way I could achieve something
close to "is in the same room as the stairs up") where it can't
interfere with solving the level.
2021-06-26 17:06:37 -07:00
Pasi Kallinen
5ea652e0c6 Explicitly check for not STONE in corridor join
... instead of relying STONE being 0
2021-06-26 16:59:11 +03:00
Pasi Kallinen
c019968997 Clear all room data
Restoring a level cleared residence pointer from those subrooms
which were in the restored level, but if the previous level had
more subrooms, those pointers weren't cleared.
This caused weird problems when a shopkeeper data was looked
up based on the subroom number.

Just to be safe, clear all the room data when freeing the level.
2021-06-26 15:10:43 +03:00
Pasi Kallinen
b5dd0f8986 Fix strange object mimic in shop sanity error
Shop population code set the mimic shape to strange object
without checking for protection from shape changers.
Let set_mimic_sym (via makemon) handle it correctly instead.
2021-06-26 13:03:28 +03:00
PatR
ddf9eb0688 still more "<mon> appears in a cloud of smoke"
For Angels who appear in a flash of light, temporarily light the
spot where they arrive.  If not previously visible, it will go back
to dark and change the angel to the remembered, unseen monster glyph,
usually before the player even notices.

Add more monsters to msummon_environ() so that it has latent support
for various light, fire, and lava creatures from mondata.h even
though these extra ones, like previous vortices, don't get summoned
by msummon().
2021-06-25 14:43:14 -07:00
PatR
4aceb467ce tribute update: The Last Continent
Add page citation to passage 2.

Add four new passages, bringing total to 14.
2021-06-25 14:29:07 -07:00
Pasi Kallinen
075844b4d6 Adjust shopkeeper damage fixing
Allow shopkeeper to remove webs and pits.

Change the damage fix messaging to be more specific when
shopkeeper removes a trap. Before this the message was
"A trap was removed from the floor", which sounds really silly
when it comes to holes.

Change the damage fixing so the shopkeeper will fix one damage spot
at a time (instead of all at once), so it's more like a monster action.

Some code cleanup, splitting into smaller functions.

While doing this, I noticed that shopkeepers don't actually bill
the hero for the damage, but that'll have to be another commit...
2021-06-25 20:02:06 +03:00
Pasi Kallinen
823b770ad9 Fix thinko in the shk litter indexing 2021-06-25 13:39:59 +03:00
Pasi Kallinen
ef9e2e36c3 Reorg shopkeeper litter routine
When shopkeeper fixes a wall and there are items on that location,
shopkeeper tries to move those items into their shop. Split
the code dealing with that into separate functions.
2021-06-25 13:22:22 +03:00
Pasi Kallinen
1e7b75eb8b Expose stairway data to lua 2021-06-24 18:55:20 +03:00
nhmall
420863252a warning in trap.c that recently appeared
src/trap.c(5410): warning C4389: '==': signed/unsigned mismatch
2021-06-24 08:52:43 -04:00
Pasi Kallinen
3ddb2a91c7 Allow some makemon flags in lua monster creation
Also document the des.monster hash parameter values.
2021-06-24 14:38:12 +03:00
Pasi Kallinen
8dfe963652 Allow spiders to spin webs
Revisited this feature, and the chance of a spider spinning a web
depends now on the number of webs already present on the level.

For a giant spider to spin a web in the middle of a room with no
supports, the limit of existing webs is 4, next to one support 9,
next to two supports 14, and so on. Cave spider limits are much lower.
2021-06-23 22:50:57 +03:00
PatR
a9134fd8b9 more "<mon> appears in a cloud of smoke"
Now that the appear message isn't limited to summoning by demon,
seeing "the Angel of <foo> appears in a cloud of smoke" seems
strange.  Angels weren't covered by the vapor/dust/&c change for
elementals.  Make angels appear in a flash of light.
2021-06-21 17:47:51 -07:00
PatR
fa7980c585 monster name formatting
While testing monster summoning by using a debugger to force the
outcome, I saw "the renegade Angel of <foo> appears in a cloud of
smoke" as if only one such creature existed.  Trying to change
that to "a renegate Angel" pointed out some problems:  type names
like Angel, Green-elf, and Uruk-hai fool an() into using "the"
because of their capital letter.  Fixing that was a bit of a hack
and worked for Green-elf and Uruk-hai but not for Angel because
it has the eminion extension so uses priestname() instead of the
guts of x_monnam().  Fixing that involved more hackery and now I
feel unclean, but it seems to be working.

It wasn't as noticeable as it might have been because most of the
time that "the Angel of <foo>" or "the priest of <bar>" was shown,
the caller is requesting "the" rather than "a/an".
2021-06-21 17:44:35 -07:00
nhmall
3af1cc79e6 k-sound follow-up 2021-06-21 15:56:14 -04:00
nhmall
b28e914bc3 revisit k-sounding ch suffix
put k-sounding suffix exception checks into a function
2021-06-21 15:42:49 -04:00
Pasi Kallinen
f84538aa8c Dehardcode number of glass gems 2021-06-21 10:06:46 +03:00
PatR
0bb77f455d "<foo> appears in cloud of smoke."
Have water demons appear in a cloud of vapor rather than a cloud of
smoke.  This adds a few other alternatives but they'll never happen.
Elementals could only be summoned by Angels but Angels never call
msummon() as far as I can tell.  Vortices aren't summoned at all
but the smoke/vapor/&c routine has provisions for them.

The cloud of smoke message used to be given only when the summoner
is a demon.  Now it will be given if the last--or only--summoned
creature can be seen to arrive, no matter whether summoned by a
demon, a non-demon (which I think isn't possible), or post-Wizard
harassment.
2021-06-20 16:45:42 -07:00
nhmall
429b665379 fix monarch pluralization 2021-06-20 07:51:53 -04:00
PatR
7552a52daa tribute: Jingo
Add two new passages to Jingo, bringing the total to 14.
2021-06-18 14:51:21 -07:00
PatR
0b5a112b0c gender for figurines
Use (obj->spe & CORPSTAT_GENDER) for figurines as well as for
statues and corpses.

Support wishing for
 "{female,male,neuter} {corpse,statue,figurine} [of <monster>]".
and
 "{female,male,neuter} <monster> {corpse,statue,figurine}".
Also
 "{corpse,statue,figurine} of {female,male,neuter} <monster>"
where the qualifier might be in the middle instead of a prefix.
2021-06-17 16:03:45 -07:00
PatR
0aaafd19be fix the "fix obj_pmname() fix"
Avoid using montraits when determining pmname of a corpse or statue.
2021-06-16 14:22:03 -07:00
Pasi Kallinen
26fa915cf3 Silence couple warnings of possibly uninitialized vars 2021-06-16 22:08:04 +03:00
Pasi Kallinen
769bce1199 Minor code reorg: finding longest option name 2021-06-16 14:53:05 +03:00
Pasi Kallinen
76f77ee0cc Add assistance to fire-command
Allows the fire-command to autowield a launcher; it will now
do either swapweapon or wield an appropriate launcher, if you
have ammo quivered.

This assistance can be turned off with the fireassist boolean option.

Adds a rudimentary command queue, which allows the code to add keys
or extended commands into the queue, and they're executed as if
the user did them.  Time passes normally when doing the queue,
and the queue will get cleared if hero is interrupted.
2021-06-16 13:14:32 +03:00
PatR
f6e60c7516 fix bullwhip-induced panic
While testing some corpse/statue name manipulation changes I managed
to trigger a panic during end-of-game cleanup.  Using a bullwhip to
snatch a wielded cockatrice corpse from a monster's inventory into
the hero's inventory and being turned to stone due to lack of gloves
took the corpse out of the monster's inventory but didn't place it
anywhere.  If no life-saving took place, it led to an "obj_is_local"
panic during timer cleanup when freeing the level.

This patch includes some of the stuff I've been testing rather than
just the fix for the panic (which is the very last bit of the diff).
2021-06-15 18:42:30 -07:00
PatR
7088f6a846 fix obj_pmname() fix
The omonst 'data' pointer is always Null so taking mons[].pmname from
saved traits would be skipped all the time.
2021-06-15 14:13:55 -07:00
nhmall
fe4822829c fixes37.0 entry update 2021-06-15 16:30:07 -04:00
nhmall
5ac913e035 null pointer dereference in do_name.c
fixes #534
2021-06-15 15:49:31 -04:00
PatR
57e970b227 mon_pmname(), obj_pmname()
Revive some code from 5 or so years ago that's been sitting in a
defunct local git branch.  There are a couple of references to
figurines having gender; the old, unfinished code did already have
support for that, the current code doesn't.  It probably won't take
much effort to add it in but I want to get this first part out of
the way.

Replace some of the
pmname(mon->data, Mgender[mon]) calls with simpler
mon_pmname(mon) and some
pmname(&mons[statue->corpsenm],
   (statue->spe & CORPSTAT_GENDER) == ... ? ... : ...) with simpler
obj_pmname(obj).  There are other instances of them which haven't
been changed but could be.
2021-06-12 03:07:30 -07:00
PatR
234eceae60 corpse/statue gender fix when wishing
Wishing for "{corpse,statue} of gnome queen" would produce a corpse or
statue of a gnome queen, but wishing for "gnome queen {corpse,statue}"
would produce corpse or statue of a gnome king.  The matching for
gender-specific monster name was only passing back the corresponding
gender when an exact match occurred (which happens for "foo of pmname"
but not for "pmname foo" since 'pmname' through end of string is what
the name_to_mon() matching code is looking at).
2021-06-12 02:25:16 -07:00